From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Mon, 09 Oct 2023 19:48:21 +0300 Message-ID: <834jizwxm2.fsf@gnu.org> References: <83wmvyzir2.fsf@gnu.org> <585dcaf0-358e-4a9d-84d1-6fd9c2c8aec5@gmail.com> <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> <83jzryz6op.fsf@gnu.org> <87a5sugwcx.fsf@gmx.de> <83h6n2z3tr.fsf@gnu.org> <831qe5znrz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manikulin@gmail.com, 66390@debbugs.gnu.org, michael.albinus@gmx.de To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 09 18:49:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qptS9-0005Rz-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Oct 2023 18:49:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qptRx-0004vN-9I; Mon, 09 Oct 2023 12:49:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qptRu-0004dU-FX for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 12:49:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qptRu-0004fa-4K for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 12:49:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qptSE-0004QZ-Og for bug-gnu-emacs@gnu.org; Mon, 09 Oct 2023 12:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Oct 2023 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.169687016316939 (code B ref 66390); Mon, 09 Oct 2023 16:50:02 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 9 Oct 2023 16:49:23 +0000 Original-Received: from localhost ([127.0.0.1]:32990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qptRa-0004P7-TO for submit@debbugs.gnu.org; Mon, 09 Oct 2023 12:49:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qptRY-0004On-Bi for 66390@debbugs.gnu.org; Mon, 09 Oct 2023 12:49:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qptR6-0004TV-1B; Mon, 09 Oct 2023 12:48:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wcyqxLdkmh1zel4PovDCoj6kfaK/NFJFs0FtCgKxIJk=; b=iL14o8bvkoo/ qcuqOJOffTUy4jE0a+QBe2T7Emt5Mu4KZvfbeDzvEIpQPZ/CquQghOst5iVebQIVNkDZnRpi8eonm gS95tm7kRx2kyFYg5vk7WbSpLFxAgFI1fc3L/eYjIr+BMAViFZveAAzXffjEWVO6uq2t7uRG5136+ jMnB2Ox+reTDt48B6HgCcbWcttQKMSNKcrflXr2Jimk2QPD+gYqFluUhLTQQ78fgIZMJDshm1UzV9 FPqrwVZz/rbB/VTotaN4Qkh8Zl1tKsH5uCFPnCoHjUTOUmRX4gPoEydCp3nyySP0U1ieu0oiYifjk tvJLmdzvH2mDD1S3enqj0Q==; In-Reply-To: (message from lux on Tue, 10 Oct 2023 00:30:06 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272155 Archived-At: > From: lux > Cc: 66390@debbugs.gnu.org, michael.albinus@gmx.de > Date: Tue, 10 Oct 2023 00:30:06 +0800 > > There is indeed an code injection vulnerability issue here, for example: > > (man ";ls") <-- The `ls' command will be executed. So does this: (shell-command "ls") Does it mean we will disallow shell-command? or forcibly quote every shell command? We cannot do that. > Here's my patch and the test cases. And I ask again: what happens with command (man "[") in this case? Please believe me: this is not simple. There's more here than meets the eye. In addition to all kinds of weird characters in man-page names, you also need to consider SEE ALSO links from one man page to another, which can cross lines and include dashes and whitespace. Etc. etc... I had my share of messing with this code, and one thing I know is that nothing is ever as simple as quoting here.