From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67536: 29.1; Calc mode's math-read-preprocess-string conses unnecessarily Date: Fri, 01 Dec 2023 20:12:46 +0200 Message-ID: <834jh1aj1d.fsf@gnu.org> References: <83h6l367zx.fsf@gnu.org> <83jzpzaw9s.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19379"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67536@debbugs.gnu.org To: Raffael Stocker Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 01 19:14:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r981q-0004mf-6H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Dec 2023 19:14:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r981U-00018K-1z; Fri, 01 Dec 2023 13:13:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r981R-00017i-OP for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 13:13:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r981R-0003dJ-GI for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 13:13:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r981Z-0005PZ-Ut for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2023 13:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Dec 2023 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67536 X-GNU-PR-Package: emacs Original-Received: via spool by 67536-submit@debbugs.gnu.org id=B67536.170145438820733 (code B ref 67536); Fri, 01 Dec 2023 18:14:01 +0000 Original-Received: (at 67536) by debbugs.gnu.org; 1 Dec 2023 18:13:08 +0000 Original-Received: from localhost ([127.0.0.1]:56063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r980h-0005OJ-OG for submit@debbugs.gnu.org; Fri, 01 Dec 2023 13:13:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r980f-0005Nm-Gh for 67536@debbugs.gnu.org; Fri, 01 Dec 2023 13:13:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r980Q-0001Wv-Eo; Fri, 01 Dec 2023 13:12:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+k9uiBcUqfHTDyFNSp/S0dgKe4BQCaUTG/bRK9jWnUs=; b=di3T9y0ALNZb sIyvzbTQ5lSYIN2qPWydKBFDYH3AJ5xOdjZTQWVL+u6ijtKAH+etFpWvBzHuQjJ4KXR7o+FJsR9VS UN1DE/oH+8Xfv6ZQCc+cfY52dmzNFfJLih0frkD4Nd2QFsdxRAvz697qXkZTFkDtU46T3bJcwso88 80T9IpjqOMvALiqRQGlAcZb6SUA0Fb1F4eYwmsj/XFnmkaWK2uiTYK4WsaW4pkIOFODLmr+VyJMJn 0X+59JvYTTaqvUknzz53O9PnC8qpuDf8Zo/P63D/BRllJwBSxDoDRyKn0HO6sb4QgQ7N27+GZLrv2 lDt5qv8uR7+QNGxXS/JAvw==; In-Reply-To: (message from Raffael Stocker on Fri, 01 Dec 2023 18:34:10 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275337 Archived-At: > From: Raffael Stocker > Cc: 67536@debbugs.gnu.org > Date: Fri, 01 Dec 2023 18:34:10 +0100 > > I cleaned it up a bit and ran a few tests against the original function > using an empty string, a string without anything to replace and a string > requiring many replacements. It seems to behave just as the original. Thanks. > I use cl-flet and (eval-when-compile (require 'cl-lib)). I hope that is > ok. I'd prefer a simple internal function, or a lambda. > + (with-temp-buffer > + (cl-flet ((replace-all (regexp replacement) > + (goto-char 0) > + (while (re-search-forward regexp nil t) > + (replace-match replacement)))) > + (insert str) > + (replace-all (concat "[" math-read-superscripts "]+") "^(\\&)") > + (replace-all (concat "[" math-read-subscripts "]+") "_(\\&)") > + (dolist (rep-elem math-read-replacement-list) > + (replace-all (car rep-elem) (cadr rep-elem))) > + (buffer-string)))) I think buffer-substring-no-properties would be better than buffer-string, as we don't need to copy any text properties, right?