From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments Date: Sun, 10 Dec 2023 11:39:31 +0200 Message-ID: <834jgqwg4s.fsf@gnu.org> References: <834jhchqha.fsf@gnu.org> <08e16d44-174d-87e6-aa17-8cf55202227b@gutov.dev> <83wmu8fsj7.fsf@gnu.org> <8334wvfdna.fsf@gnu.org> <83y1endx9z.fsf@gnu.org> <83cyvs7jte.fsf@gnu.org> <83ttoryebi.fsf@gnu.org> <8c7e244d-5dad-4111-89b8-ca7722657ce0@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1637"; mail-complaints-to="usenet@ciao.gmane.io" Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 10 10:41:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCGJN-0000Gz-21 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Dec 2023 10:41:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCGJ5-0004rQ-BT; Sun, 10 Dec 2023 04:41:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCGJ3-0004rG-RY for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:41:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCGIp-0004R2-Uk for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCGJ3-0005Gg-W4 for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 04:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Dec 2023 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67357-submit@debbugs.gnu.org id=B67357.170220120820164 (code B ref 67357); Sun, 10 Dec 2023 09:41:01 +0000 Original-Received: (at 67357) by debbugs.gnu.org; 10 Dec 2023 09:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:49508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCGIC-0005F8-3h for submit@debbugs.gnu.org; Sun, 10 Dec 2023 04:40:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCGIA-0005Ed-96 for 67357@debbugs.gnu.org; Sun, 10 Dec 2023 04:40:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCGHq-000408-99; Sun, 10 Dec 2023 04:39:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=65GR7y7vhUGRKRNh5cSZKPWMupjmfgd9DR/V6IRrrRA=; b=iRvvOowzFCdQ DuBgM9rGnBJSvslq812WDVYh2+eBYegNQbtp4KOFAy+2ASeC+KO8Kb1GleyB9qVXxIuM3EKxvlRt9 Zlf4EFd4ngOxXXCZikghwjTdV6VocshOBvtb8Ib+DN7eeWFeTSpUmVgH5O7VnFP06yEYAdPv8fsvW MrCSWf2KDLZq+Ey8tfOh/K++Zxo9EzkhLpWM765mSxZ6kwSZE6Zrd6yzYPTBspC+feLh9WoqpDFaF yGsjFPm5BfTL01JHQvGwgN67yVGUG+YsmKqdfxP7fKCasv5nr9SOpaYrnnu38mw7z8SXUrJFuSJk+ h5DTSvMO2lVM6cfhrwm9hA==; In-Reply-To: <8c7e244d-5dad-4111-89b8-ca7722657ce0@gmail.com> (message from Yuan Fu on Sun, 10 Dec 2023 01:09:15 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275906 Archived-At: > Date: Sun, 10 Dec 2023 01:09:15 -0800 > Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev > From: Yuan Fu > > > > Ping! Ping! Yuan, please chime is, as I'm waiting for your comments > > before we install on the release branch. > > > > This and other patches for TS-based modes are currently delaying the > > release of Emacs 29.2, so please try to be more responsive, okay? > > > Whoa! Sorry, I just switched to a new email client, and direct CC isn't > highlight as they were before :-( (And admittedly I haven't been > browsing the bug tracker lately.) OK, but please look also at other bugs and issues where I asked for your opinions. > As for the patch, first of all, thank you, Noah, it's very good. I try > to avoid query matchers since they could be slow, plus the fundamental > problem isn't with comments, IMO. The problem is when the first sibling > isn't on it's own line. (Though in normal C source code, when the first > sibling isn't on its own line, that sibling is usually a comment.) > Anyway, please see my reasoning in the commit message for 08fc6bace20. > > I also removed the else_clause rule since it's already added by the > patch for bug#67417, and added another test. Thanks, but please in the future mention _all_ relevant bug numbers in the log message, or merge them if appropriate.