From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 1 Jun 2024 17:13:13 +0300 Message-ID: <8349bbd4-21e5-4c11-aae9-28cef1aa231a@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14084"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71209@debbugs.gnu.org To: Noah Peart , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 16:14:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDPUk-0003Tn-P0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 16:14:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDPUX-0003kv-8h; Sat, 01 Jun 2024 10:13:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDPUV-0003kO-3b for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:13:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDPUU-0001pR-RZ for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:13:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDPUg-0006yX-1N for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171725121826774 (code B ref 71209); Sat, 01 Jun 2024 14:14:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 14:13:38 +0000 Original-Received: from localhost ([127.0.0.1]:56967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDPUI-0006xm-5a for submit@debbugs.gnu.org; Sat, 01 Jun 2024 10:13:38 -0400 Original-Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]:58575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDPUF-0006xX-7i for 71209@debbugs.gnu.org; Sat, 01 Jun 2024 10:13:36 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.west.internal (Postfix) with ESMTP id 62CBF1C000CD; Sat, 1 Jun 2024 10:13:17 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 01 Jun 2024 10:13:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717251197; x=1717337597; bh=V+3+DQnYlInqN4NfQVZZjBjhjCcJtwZH2UQ44uRjXbA=; b= N8TKp0z7sCEmR+Qb7YP+pbDukP1fV6rWyIjTlz/+XQDYGhsMxLSvpUmY8DvzfnNO 5I+ODrqFcFS1BAmPZcXeLT7VIxbFs9QE7ubg6pldkVjh87xgRwu3tJAkAwJbdkKc 95fv+t4qinJGiC+rdGjGw1YFphAJ0uhUa+A8HzRLJu3fSjydNZ8CJ+zTnGaMTXIG 5ME4gm3zAmTIyOaraZ7ZgzTijUufSbMAccrvQ4tKXADKzF84vRoleJ4RCdnOPVZr T4AzPuZG9BOXwVV0ZNr5VohsEVes+Ze0eFHfn0ZNRfqhaoBcdFPidJyO/vp8PG9y TjUM0tB6yGGJ1e44a8g4Iw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717251197; x= 1717337597; bh=V+3+DQnYlInqN4NfQVZZjBjhjCcJtwZH2UQ44uRjXbA=; b=Q DTggoodBP9xiaanK+6oIDPt6wxqlBAFSONXzbaR126NN2E85yFBafIE6F9go0cjX qEZJtvfPmCP05AudLWZr0L2tSGPhWlAyTu1hqSHI55Yyxxey8s0QhPX0epChJL6z PLeWMduirVpJOtFGOWVg4IKbK6EkaaWn1YgBCBUzx8O2ziFr/HkB5XB7FNOEHFAD QrLXiIXOpORSs0nXL5L9oAB2QoG2BxPOc3GtboTY/Zvn0+oUp1amkFRFpQzwyqNy 8oANCFkniY1qjib8zk2A84fhA6iguQefcSMWisu2EYUWwh2foa9QJpIPMbylpY48 IiWxx0SpbvmH6BX0+w8tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekkedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Jun 2024 10:13:15 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286324 Archived-At: On 01/06/2024 04:50, Noah Peart wrote: > There is a similar issue with font-lock-property-name-face > and font-lock-property-use-face.  I've noticed different modes > treat things differently.  I think object fields in literals should get > property-name-face, but json-ts-mode, for example, > doesn't use font-lock-property-name-face at all. Yeah, that sounds about right. Probably needs some formalization, because for cases like json and html I wasn't 100% sure which semantics to choose, and unlike in programming code this didn't seem urgent at the time.