unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: 9571@debbugs.gnu.org, stepnem@gmail.com
Subject: bug#9571: 24.0.50; user option to turn off bidi, please
Date: Sat, 24 Sep 2011 17:13:40 +0300	[thread overview]
Message-ID: <8339fmt4dn.fsf@gnu.org> (raw)
In-Reply-To: <E1R7RLT-0008Vf-BA@fencepost.gnu.org>

> Date: Sat, 24 Sep 2011 08:28:39 -0400
> From: Richard Stallman <rms@gnu.org>
> CC: stepnem@gmail.com, 9571@debbugs.gnu.org
> 
> Would this change in bidi_get_type suffice to implement non-bidi
> display?  (In addition, one needs to define the option
> display-bidi-flag, etc.)
> [...]
> +   if (NILP (Vdisplay_bidi_flag))
> +     return default_type;
> + 

No, this won't do what you want.  default_type comes from this code:

  default_type = (bidi_type_t) XINT (CHAR_TABLE_REF (bidi_type_table, ch));

This accesses the table of bidirectional properties and extracts from
there the bidirectional type of CH, the character we are interested
in.  The rest of the code deals with _overriding_ that type.  For any
R2L character, default_type is STRONG_R, and it will cause bidi.c to
reorder it into visual order.

What you want is to pretend that R2L characters get the type STRONG_L,
which is the type reserved for letters in left-to-right scripts.

But simply overwriting default_type with STRONG_L isn't right, either.
That's because as long as we run the code in bidi.c unaltered, there
are some characters whose bidirectional properties are still needed
for the code to work: newlines, paragraph separators, line separators,
and a few others.

So my suggestion to have what you want is different, see my other
mail.

> If it is really as easy as this, why say no?

I didn't say no to this suggestion, because it was never explicitly
requested, from my POV.  If you meant this from the beginning, then
I'm sorry for my misunderstanding of what you meant.

However, I'm quite sure I did understand the original request that
started this, and it wasn't this.





  reply	other threads:[~2011-09-24 14:13 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22  4:18 bug#9571: 24.0.50; user option to turn off bidi, please Drew Adams
2011-09-22  5:49 ` Eli Zaretskii
2011-09-22 12:31 ` Stefan Monnier
2011-09-22 13:13   ` Drew Adams
2011-09-22 21:44     ` Richard Stallman
2011-09-23  4:13       ` Stefan Monnier
2011-09-23 12:31         ` Richard Stallman
2011-09-23 14:46           ` Eli Zaretskii
2011-09-23 14:55             ` Lars Magne Ingebrigtsen
2011-09-23 15:06               ` Eli Zaretskii
2011-09-23 17:36                 ` Stefan Monnier
2011-09-23 18:23                 ` Lars Magne Ingebrigtsen
2011-09-23 19:44             ` Richard Stallman
2011-09-23 20:09               ` Eli Zaretskii
2011-09-24  3:56           ` Jason Rumney
2011-09-24 12:28             ` Richard Stallman
2011-09-23  9:13       ` Eli Zaretskii
2011-09-23 12:31         ` Richard Stallman
2011-09-23 14:40           ` Eli Zaretskii
2011-09-23 19:44             ` Richard Stallman
2011-09-23 19:48               ` Eli Zaretskii
2011-09-24 12:28                 ` Richard Stallman
2011-09-24 14:04                   ` Eli Zaretskii
2011-09-24 17:30                     ` Richard Stallman
2011-09-24 19:15                       ` Eli Zaretskii
2011-09-24 23:52                         ` Richard Stallman
2011-09-23  4:11     ` Stefan Monnier
2011-09-23  8:01       ` Štěpán Němec
2011-09-23  9:21         ` Juanma Barranquero
2011-09-23 10:39           ` Štěpán Němec
2011-09-23 11:01             ` Eli Zaretskii
2011-09-23 16:09               ` Drew Adams
2011-09-23 17:48                 ` Eli Zaretskii
2011-09-23 19:03                   ` Drew Adams
2011-09-23 19:46                     ` Eli Zaretskii
2011-09-23 21:23                       ` Drew Adams
2011-09-23 23:21                         ` Juanma Barranquero
2011-09-24  0:32                           ` Drew Adams
2011-09-24  1:13                             ` Juanma Barranquero
2011-09-24  3:46                               ` Drew Adams
2011-09-24  8:44                                 ` Juanma Barranquero
2012-02-22  2:34                                   ` Glenn Morris
2011-09-24  6:49                             ` Eli Zaretskii
2011-09-24  8:46                               ` Juanma Barranquero
2011-09-23 20:00                     ` Stefan Monnier
2011-09-23 10:18         ` Eli Zaretskii
2011-09-23 11:09           ` Štěpán Němec
2011-09-23 11:45             ` Juanma Barranquero
2011-09-23 13:01               ` Štěpán Němec
2011-09-23 15:03                 ` Eli Zaretskii
2011-09-23 17:46                   ` Stefan Monnier
2011-09-23 18:24                     ` Eli Zaretskii
2011-09-23 19:10                       ` Eli Zaretskii
2011-09-23 11:50             ` Eli Zaretskii
2011-09-24 12:28               ` Richard Stallman
2011-09-24 14:13                 ` Eli Zaretskii [this message]
2011-09-24  3:53 ` Jason Rumney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8339fmt4dn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=9571@debbugs.gnu.org \
    --cc=rms@gnu.org \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).