From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12945: Assume POSIX 1003.1-1988 or later for unistd.h. Date: Tue, 20 Nov 2012 22:13:35 +0200 Message-ID: <833904vxqo.fsf@gnu.org> References: <50ABC017.7060802@cs.ucla.edu> <83fw44w38g.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353442498 23034 80.91.229.3 (20 Nov 2012 20:14:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Nov 2012 20:14:58 +0000 (UTC) Cc: 12945@debbugs.gnu.org To: eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 20 21:15:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TauDq-0006nV-DE for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2012 21:15:06 +0100 Original-Received: from localhost ([::1]:42130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TauDf-0006nZ-MH for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2012 15:14:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TauDc-0006nA-T9 for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2012 15:14:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TauDb-000654-SA for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2012 15:14:52 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TauDb-000650-OW for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2012 15:14:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TauEk-0003A8-D3 for bug-gnu-emacs@gnu.org; Tue, 20 Nov 2012 15:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Nov 2012 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12945-submit@debbugs.gnu.org id=B12945.135344250912093 (code B ref 12945); Tue, 20 Nov 2012 20:16:02 +0000 Original-Received: (at 12945) by debbugs.gnu.org; 20 Nov 2012 20:15:09 +0000 Original-Received: from localhost ([127.0.0.1]:57348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TauDt-000390-KW for submit@debbugs.gnu.org; Tue, 20 Nov 2012 15:15:09 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:39261) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TauDr-00038s-6y for 12945@debbugs.gnu.org; Tue, 20 Nov 2012 15:15:08 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MDS00800XTH0700@a-mtaout22.012.net.il> for 12945@debbugs.gnu.org; Tue, 20 Nov 2012 22:13:55 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDS008LEYV67Z10@a-mtaout22.012.net.il>; Tue, 20 Nov 2012 22:13:55 +0200 (IST) In-reply-to: <83fw44w38g.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67242 Archived-At: > Date: Tue, 20 Nov 2012 20:14:55 +0200 > From: Eli Zaretskii > Cc: 12945@debbugs.gnu.org > > > It may help in a later patch to simplify the Microsoft side by > > removing getwd and standardizing on getcwd, since that's what > > POSIX did back in 1988, but that's an issue that's independent > > of this patch. > > It's not independent. The getwd in w32.c must be modified to be > getcwd instead. Here's the patch for that: === modified file 'src/w32.c' --- src/w32.c 2012-11-17 22:12:47 +0000 +++ src/w32.c 2012-11-20 20:11:08 +0000 @@ -901,8 +901,18 @@ static char startup_dir[MAXPATHLEN]; /* Get the current working directory. */ char * -getwd (char *dir) +getcwd (char *dir, int dirsize) { + if (!dirsize) + { + errno = EINVAL; + return NULL; + } + if (dirsize < strlen (startup_dir) + 1) + { + errno = ERANGE; + return NULL; + } #if 0 if (GetCurrentDirectory (MAXPATHLEN, dir) > 0) return dir;