From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12993: Wrong icon for Cygw32-Emacs Date: Mon, 10 Dec 2012 18:34:21 +0200 Message-ID: <8338zdc1de.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <50C607C8.3050003@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1355157406 30312 80.91.229.3 (10 Dec 2012 16:36:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2012 16:36:46 +0000 (UTC) Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 10 17:36:59 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ti6Lf-0004Cx-F2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 17:36:55 +0100 Original-Received: from localhost ([::1]:49183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6LS-0008NH-Ut for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 11:36:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6LG-0007tf-UD for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 11:36:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti6LC-0005P5-A3 for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 11:36:30 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6LC-0005Ot-6m for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 11:36:26 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ti6Ll-00080l-NU for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 11:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Dec 2012 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12993-submit@debbugs.gnu.org id=B12993.135515736830733 (code B ref 12993); Mon, 10 Dec 2012 16:37:01 +0000 Original-Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 16:36:08 +0000 Original-Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6Kt-0007ze-S3 for submit@debbugs.gnu.org; Mon, 10 Dec 2012 11:36:08 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:61392) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti6Kr-0007zV-OJ for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 11:36:07 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MET00D00PVC2C00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 18:34:29 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00CB7Q1H6KH0@a-mtaout22.012.net.il>; Mon, 10 Dec 2012 18:34:29 +0200 (IST) In-reply-to: <50C607C8.3050003@dancol.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68280 Archived-At: > Date: Mon, 10 Dec 2012 08:03:20 -0800 > From: Daniel Colascione > CC: angelo.graziosi@alice.it, 12993@debbugs.gnu.org > > > Why are such changes committed to the release branch? This is a minor > > feature, certainly not a bugfix, while the changes are definitely > > non-trivial. Please don't do that without discussion. > > > > It's a minor bugfix, not a feature. I guess we disagree about the definitions of these. Me, I don't see how not seeing a smalll icon in a build that was never supported by Emacs until now can be a bug. > I was under the impression that the release branch was _for_ minor > bugfixes. Enough people have complained about the icon missing from > the cygw32 build that I thought it would be worthwhile to fix it > before release. If it were a simple fix, perhaps. But it isn't, and it touches 2 other builds, that don't have this problem, in non-trivial ways. If you insist on having this in 24.3, then please at least make it Cygwin-only. For the source changes, this is easy -- use #ifdef. For emacs.rc, I hope you can do the same. If not, I'd go as far as providing a separate cygw32.rc file. The MSDOS problems are on me -- you will owe me ;-) OK?