unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it
Subject: bug#12993: Wrong icon for Cygw32-Emacs
Date: Mon, 10 Dec 2012 18:34:21 +0200	[thread overview]
Message-ID: <8338zdc1de.fsf@gnu.org> (raw)
In-Reply-To: <50C607C8.3050003@dancol.org>

> Date: Mon, 10 Dec 2012 08:03:20 -0800
> From: Daniel Colascione <dancol@dancol.org>
> CC: angelo.graziosi@alice.it, 12993@debbugs.gnu.org
> 
> > Why are such changes committed to the release branch?  This is a minor
> > feature, certainly not a bugfix, while the changes are definitely
> > non-trivial.  Please don't do that without discussion.
> >
> 
> It's a minor bugfix, not a feature.

I guess we disagree about the definitions of these.  Me, I don't see
how not seeing a smalll icon in a build that was never supported by
Emacs until now can be a bug.

> I was under the impression that the release branch was _for_ minor
> bugfixes. Enough people have complained about the icon missing from
> the cygw32 build that I thought it would be worthwhile to fix it
> before release.

If it were a simple fix, perhaps.  But it isn't, and it touches 2
other builds, that don't have this problem, in non-trivial ways.

If you insist on having this in 24.3, then please at least make it
Cygwin-only.  For the source changes, this is easy -- use #ifdef.  For
emacs.rc, I hope you can do the same.  If not, I'd go as far as
providing a separate cygw32.rc file.

The MSDOS problems are on me -- you will owe me ;-)

OK?





  reply	other threads:[~2012-12-10 16:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25 14:49 bug#12993: Wrong icon for Cygw32-Emacs Angelo Graziosi
2012-12-10  7:13 ` Daniel Colascione
2012-12-10 13:40   ` Eli Zaretskii
2012-12-10 14:08     ` Eli Zaretskii
2012-12-10 16:24       ` Daniel Colascione
2012-12-10 19:57         ` Eli Zaretskii
2012-12-10 21:05           ` Daniel Colascione
2012-12-10 16:03     ` Daniel Colascione
2012-12-10 16:34       ` Eli Zaretskii [this message]
2012-12-10 17:30       ` Stefan Monnier
2012-12-10 17:58         ` Daniel Colascione
2012-12-10 20:06           ` Eli Zaretskii
2013-04-07 18:11   ` Ken Brown
2013-04-07 18:48     ` Eli Zaretskii
2013-04-07 22:44       ` Ken Brown
2013-04-08  2:39         ` Eli Zaretskii
2013-04-08 13:02           ` Ken Brown
2013-04-08 14:53             ` Eli Zaretskii
2013-04-08 15:25               ` Ken Brown
2013-04-08 16:24                 ` Eli Zaretskii
2013-04-08 16:58                   ` Ken Brown
2013-04-08 17:20                     ` Eli Zaretskii
2013-04-08 20:26                       ` Ken Brown
2013-04-09  2:41                         ` Eli Zaretskii
2013-04-09  2:43                         ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8338zdc1de.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12993@debbugs.gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=dancol@dancol.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).