unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gundaetiapo@gmail.com
Cc: 14780@debbugs.gnu.org
Subject: bug#14780: Regression: C-n doesn't go to next line	under	simple	circumstances
Date: Sat, 20 Jul 2013 12:09:32 +0300	[thread overview]
Message-ID: <8338r9zjg3.fsf@gnu.org> (raw)
In-Reply-To: <834nbpzl4s.fsf@gnu.org>

> Date: Sat, 20 Jul 2013 11:33:07 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 14780@debbugs.gnu.org
> 
> Does the following fix the problem for you?

Sorry, that change had a bug.  Please try this instead:

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2013-07-16 21:35:45 +0000
+++ src/xdisp.c	2013-07-20 09:05:11 +0000
@@ -15608,10 +15608,11 @@ redisplay_window (Lisp_Object window, in
 	     the Y coordinate of the _next_ row, see the definition of
 	     MATRIX_ROW_BOTTOM_Y.  */
 	  if (w->cursor.vpos < margin + header_line)
-	    new_vpos
-	      = pixel_margin + (header_line
-				? CURRENT_HEADER_LINE_HEIGHT (w)
-				: 0) + frame_line_height;
+	    {
+	      w->cursor.vpos = -1;
+	      clear_glyph_matrix (w->desired_matrix);
+	      goto try_to_scroll;
+	    }
 	  else
 	    {
 	      int window_height = window_box_height (w);
@@ -15619,7 +15620,11 @@ redisplay_window (Lisp_Object window, in
 	      if (header_line)
 		window_height += CURRENT_HEADER_LINE_HEIGHT (w);
 	      if (w->cursor.y >= window_height - pixel_margin)
-		new_vpos = window_height - pixel_margin;
+		{
+		  w->cursor.vpos = -1;
+		  clear_glyph_matrix (w->desired_matrix);
+		  goto try_to_scroll;
+		}
 	    }
 	}
 






  reply	other threads:[~2013-07-20  9:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03 16:03 bug#14780: Regression: C-n doesn't go to next line under simple circumstances Barry OReilly
     [not found] ` <handler.14780.B.13728674128397.ack@debbugs.gnu.org>
2013-07-19 18:37   ` bug#14780: Acknowledgement (Regression: C-n doesn't go to next line under simple circumstances) Barry OReilly
2013-07-19 19:14     ` Eli Zaretskii
2013-07-19 19:53       ` Barry OReilly
2013-07-19 20:30         ` bug#14780: Regression: C-n doesn't go to next line under simple circumstances Eli Zaretskii
2013-07-19 20:37           ` Barry OReilly
2013-07-20  6:42             ` Eli Zaretskii
2013-07-20  8:33               ` Eli Zaretskii
2013-07-20  9:09                 ` Eli Zaretskii [this message]
2013-07-22 20:37                   ` Barry OReilly
2013-07-24 17:38                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8338r9zjg3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=14780@debbugs.gnu.org \
    --cc=gundaetiapo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).