From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Date: Fri, 13 Jun 2014 11:29:44 +0300 Message-ID: <8338f9xldz.fsf@gnu.org> References: <87ioo5cn1m.fsf@tanger.home> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1402648297 31139 80.91.229.3 (13 Jun 2014 08:31:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2014 08:31:37 +0000 (UTC) Cc: 17769@debbugs.gnu.org To: Daimrod Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 13 10:31:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WvMtT-0004dD-UQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 10:31:28 +0200 Original-Received: from localhost ([::1]:57444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvMtT-0008W5-GF for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 04:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvMtC-0008Jg-4E for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 04:31:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvMt4-0004RN-LX for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 04:31:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvMt4-0004RJ-IA for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 04:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvMt4-0007CO-1J for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 04:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 08:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140264820727586 (code B ref 17769); Fri, 13 Jun 2014 08:31:01 +0000 Original-Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 08:30:07 +0000 Original-Received: from localhost ([127.0.0.1]:46148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvMsA-0007AK-V2 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 04:30:07 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:60071) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvMs7-000792-D3 for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 04:30:05 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N7300700M2VT300@a-mtaout23.012.net.il> for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 11:29:56 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N73007QXM9VQ170@a-mtaout23.012.net.il>; Fri, 13 Jun 2014 11:29:56 +0300 (IDT) In-reply-to: <87ioo5cn1m.fsf@tanger.home> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90312 Archived-At: > From: Daimrod > Date: Fri, 13 Jun 2014 15:59:33 +0900 > > The attached patch prevents `rcirc-omit-mode' to call `recenter' when > `window-buffer' isn't the same as `current-buffer'. > > > If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c > C-o) then it will do the right thing. > > If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we > don't need to `recenter' the buffer, because it will be done the next > time the user switch to the buffer with `rcirc-next-active-buffer'. > > I'm not an RCIRC expert, but I don't think anything else is required. > WDYT? This doesn't sound like the right fix to me. Instead, the code should momentarily switch to the right window, and call recenter there. That's surely what the author of this code intended, AFAIU. Thanks.