unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daimrod <daimrod@gmail.com>
Cc: 17769@debbugs.gnu.org
Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display	current-buffer.
Date: Fri, 13 Jun 2014 11:29:44 +0300	[thread overview]
Message-ID: <8338f9xldz.fsf@gnu.org> (raw)
In-Reply-To: <87ioo5cn1m.fsf@tanger.home>

> From: Daimrod <daimrod@gmail.com>
> Date: Fri, 13 Jun 2014 15:59:33 +0900
> 
> The attached patch prevents `rcirc-omit-mode' to call `recenter' when
> `window-buffer' isn't the same as `current-buffer'.
> 
> 
> If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c
> C-o) then it will do the right thing.
> 
> If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we
> don't need to `recenter' the buffer, because it will be done the next
> time the user switch to the buffer with `rcirc-next-active-buffer'.
> 
> I'm not an RCIRC expert, but I don't think anything else is required.
> WDYT?

This doesn't sound like the right fix to me.  Instead, the code should
momentarily switch to the right window, and call recenter there.
That's surely what the author of this code intended, AFAIU.

Thanks.





  reply	other threads:[~2014-06-13  8:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  6:59 bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer Daimrod
2014-06-13  8:29 ` Eli Zaretskii [this message]
2014-06-13  9:14   ` Daimrod
2014-06-13  9:38     ` Eli Zaretskii
2014-06-13  9:54       ` Daimrod
2014-06-13 12:21         ` Eli Zaretskii
2014-06-13 12:51           ` martin rudalics
2014-06-13 13:30             ` Eli Zaretskii
2014-06-13 14:23               ` martin rudalics
2014-06-13 16:08                 ` Daimrod
2014-06-19 11:18                   ` Leo Liu
2014-06-13 12:51     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8338f9xldz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=17769@debbugs.gnu.org \
    --cc=daimrod@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).