From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode Date: Mon, 27 Jul 2015 19:25:33 +0300 Message-ID: <833809zhxe.fsf@gnu.org> References: <87r3nwb4t4.fsf@gmail.com> <838ua419gg.fsf@gnu.org> <55B3D2C3.8060007@gmx.at> <83y4i4ysp2.fsf@gnu.org> <55B4C42C.8020205@gmx.at> <83si8bynpl.fsf@gnu.org> <55B6561E.40108@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1438014384 20090 80.91.229.3 (27 Jul 2015 16:26:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jul 2015 16:26:24 +0000 (UTC) Cc: 21132@debbugs.gnu.org, flitterio@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 27 18:26:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZJlEB-0005mJ-VA for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jul 2015 18:26:12 +0200 Original-Received: from localhost ([::1]:54532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJlEB-0000As-Ba for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Jul 2015 12:26:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJlE7-000084-AV for bug-gnu-emacs@gnu.org; Mon, 27 Jul 2015 12:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJlE3-00076C-4D for bug-gnu-emacs@gnu.org; Mon, 27 Jul 2015 12:26:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJlE2-00075p-Qj for bug-gnu-emacs@gnu.org; Mon, 27 Jul 2015 12:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZJlE2-0005UA-FV for bug-gnu-emacs@gnu.org; Mon, 27 Jul 2015 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jul 2015 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21132-submit@debbugs.gnu.org id=B21132.143801434921067 (code B ref 21132); Mon, 27 Jul 2015 16:26:02 +0000 Original-Received: (at 21132) by debbugs.gnu.org; 27 Jul 2015 16:25:49 +0000 Original-Received: from localhost ([127.0.0.1]:60437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJlDo-0005Tj-Q8 for submit@debbugs.gnu.org; Mon, 27 Jul 2015 12:25:49 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:49301) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJlDl-0005TT-R4 for 21132@debbugs.gnu.org; Mon, 27 Jul 2015 12:25:47 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NS500N00MQVAS00@mtaout28.012.net.il> for 21132@debbugs.gnu.org; Mon, 27 Jul 2015 19:25:48 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS500FC9MZ0EF80@mtaout28.012.net.il>; Mon, 27 Jul 2015 19:25:48 +0300 (IDT) In-reply-to: <55B6561E.40108@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105169 Archived-At: > Date: Mon, 27 Jul 2015 18:02:38 +0200 > From: martin rudalics > CC: flitterio@gmail.com, 21132@debbugs.gnu.org > > >> >> And do we prefer (FRAME_W32_WINDOW (f) != 0) to (!FRAME_W32_WINDOW (f))? > >> > > >> > We prefer !FRAME_W32_P (f) > >> > >> x_set_foreground_color, x_set_background_color and x_set_mouse_color use > >> > >> if (FRAME_W32_WINDOW (f) != 0) > >> > >> Should these be changed? > > > > No, I don't think so, because these are handlers for w32 frame > > parameters, and I see no way they could be called from Lisp, except in > > that context. Am I missing something? > > No. I asked because of your preference stated above. Although in all > the cases I cited we probably just care about whether the frame exists > at all. Yet I would feel better with a more stringent predicate that > would combine say, FRAME_W32_WINDOW and FRAME_W32_P. When FRAME_W32_P returns false, FRAME_W32_WINDOW will crash.