From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 21132@debbugs.gnu.org, flitterio@gmail.com
Subject: bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode
Date: Mon, 27 Jul 2015 19:25:33 +0300 [thread overview]
Message-ID: <833809zhxe.fsf@gnu.org> (raw)
In-Reply-To: <55B6561E.40108@gmx.at>
> Date: Mon, 27 Jul 2015 18:02:38 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: flitterio@gmail.com, 21132@debbugs.gnu.org
>
> >> >> And do we prefer (FRAME_W32_WINDOW (f) != 0) to (!FRAME_W32_WINDOW (f))?
> >> >
> >> > We prefer !FRAME_W32_P (f)
> >>
> >> x_set_foreground_color, x_set_background_color and x_set_mouse_color use
> >>
> >> if (FRAME_W32_WINDOW (f) != 0)
> >>
> >> Should these be changed?
> >
> > No, I don't think so, because these are handlers for w32 frame
> > parameters, and I see no way they could be called from Lisp, except in
> > that context. Am I missing something?
>
> No. I asked because of your preference stated above. Although in all
> the cases I cited we probably just care about whether the frame exists
> at all. Yet I would feel better with a more stringent predicate that
> would combine say, FRAME_W32_WINDOW and FRAME_W32_P.
When FRAME_W32_P returns false, FRAME_W32_WINDOW will crash.
next prev parent reply other threads:[~2015-07-27 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 16:03 bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode Francis Litterio
2015-07-25 16:35 ` Eli Zaretskii
2015-07-25 18:17 ` martin rudalics
2015-07-25 18:53 ` Eli Zaretskii
2015-07-26 11:27 ` martin rudalics
2015-07-26 14:53 ` Eli Zaretskii
2015-07-27 16:02 ` martin rudalics
2015-07-27 16:25 ` Eli Zaretskii [this message]
2015-07-27 16:34 ` martin rudalics
2015-07-27 16:59 ` Eli Zaretskii
2015-08-24 8:17 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833809zhxe.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21132@debbugs.gnu.org \
--cc=flitterio@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).