unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 28834@debbugs.gnu.org
Subject: bug#28834: 25.1; dired-do-copy: allow to copy into a nonexistent directory
Date: Tue, 17 Oct 2017 19:36:33 +0300	[thread overview]
Message-ID: <83376hg29a.fsf@gnu.org> (raw)
In-Reply-To: <87376i2xb5.fsf@gmail.com> (message from Tino Calancha on Tue, 17 Oct 2017 13:49:34 +0900)

> From: Tino Calancha <tino.calancha@gmail.com>
> Cc: 28834@debbugs.gnu.org,  drew.adams@oracle.com
> Date: Tue, 17 Oct 2017 13:49:34 +0900
> 
> * I have changed the new function name to `dired-maybe-create-dirs'
>   as Drew suggested.
> * I think I have addressed all your comments as well.

Thanks, this LGTM.  One minor comment:

> +(defun dired-maybe-create-dirs (dir)
> +  "Create DIR if doesn't exist according with `dired-create-destination-dirs'."
                                  ^^^^^^^^^^^^^^
"according to"

Please push to master in a few days, if no one raises any issues.





  reply	other threads:[~2017-10-17 16:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 10:54 bug#28834: 25.1; Dired+ not copy file to nonexistent directory alexei28
2017-10-14 15:50 ` Drew Adams
2017-10-15  4:42 ` bug#28834: 25.1; dired-do-copy: allow to copy into a " Tino Calancha
2017-10-15 14:21   ` Eli Zaretskii
2017-10-15 14:47     ` Tino Calancha
2017-10-15 15:43   ` Drew Adams
2017-10-16  3:47     ` Tino Calancha
2017-10-16 16:12       ` Eli Zaretskii
2017-10-17  4:49         ` Tino Calancha
2017-10-17 16:36           ` Eli Zaretskii [this message]
2017-10-21  4:13             ` Tino Calancha
2017-10-17  1:49       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83376hg29a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28834@debbugs.gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).