From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Thu, 21 Jun 2018 05:44:08 +0300 Message-ID: <8336xgsvt3.fsf@gnu.org> References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529548990 2819 195.159.176.226 (21 Jun 2018 02:43:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Jun 2018 02:43:10 +0000 (UTC) Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 21 04:43:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpYv-0000d6-Hi for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 04:43:05 +0200 Original-Received: from localhost ([::1]:52709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVpb1-00008p-39 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 22:45:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVpau-00007L-7U for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 22:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVpap-0004Ul-B6 for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 22:45:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVpap-0004US-6S for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 22:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVpao-0007JU-RO for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 22:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jun 2018 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152954906327875 (code B ref 30190); Thu, 21 Jun 2018 02:45:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 21 Jun 2018 02:44:23 +0000 Original-Received: from localhost ([127.0.0.1]:58112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpa9-0007FR-UL for submit@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVpa7-0007EY-1z for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVpZz-0003fl-Ao for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 22:44:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVpZs-0003bF-RV; Wed, 20 Jun 2018 22:44:04 -0400 Original-Received: from [176.228.60.248] (port=4793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fVpZr-0000JY-7B; Wed, 20 Jun 2018 22:44:03 -0400 In-reply-to: <87602drqan.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 Jun 2018 19:28:32 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147683 Archived-At: > From: Noam Postavsky > Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com > Date: Wed, 20 Jun 2018 19:28:32 -0400 > > Eli Zaretskii writes: > > > I'm for fixing this in Emacs 26.2, but I still don't think I > > understand why the latest patch proposed in the discussion of this bug > > needs to "steal" so much from comint.el? > > > > Also, why does term-watch-for-password-prompt need to be invoked via a > > hook? > > I don't these things are really required; as far as I understand, Tino > did it that way in order to be safer: the "stealing" is to avoid loading > comint.el, and using the hook is to keep the code closer to the already > working example it's being copied from. Why is it a problem to load comint? Either in this case or even always? As for the hook: it looks strange to me to use hooks for this purpose, since IMO we are supposed to refrain from doing that as much as possible.