From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com
Subject: bug#30190: 27.0.50; term run in line mode shows user passwords
Date: Thu, 21 Jun 2018 05:44:08 +0300 [thread overview]
Message-ID: <8336xgsvt3.fsf@gnu.org> (raw)
In-Reply-To: <87602drqan.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 Jun 2018 19:28:32 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com
> Date: Wed, 20 Jun 2018 19:28:32 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I'm for fixing this in Emacs 26.2, but I still don't think I
> > understand why the latest patch proposed in the discussion of this bug
> > needs to "steal" so much from comint.el?
> >
> > Also, why does term-watch-for-password-prompt need to be invoked via a
> > hook?
>
> I don't these things are really required; as far as I understand, Tino
> did it that way in order to be safer: the "stealing" is to avoid loading
> comint.el, and using the hook is to keep the code closer to the already
> working example it's being copied from.
Why is it a problem to load comint? Either in this case or even
always?
As for the hook: it looks strange to me to use hooks for this purpose,
since IMO we are supposed to refrain from doing that as much as
possible.
next prev parent reply other threads:[~2018-06-21 2:44 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 12:16 bug#30190: 27.0.50; term run in line mode shows user passwords Tino Calancha
2018-01-21 14:01 ` Noam Postavsky
2018-01-21 21:08 ` Tino Calancha
2018-02-03 16:15 ` Tino Calancha
2018-02-03 16:44 ` Noam Postavsky
2018-02-04 2:23 ` Tino Calancha
2018-02-04 2:29 ` Noam Postavsky
2018-02-04 3:37 ` Tino Calancha
2018-02-05 1:07 ` Richard Stallman
2018-02-03 17:08 ` Eli Zaretskii
2018-02-04 2:26 ` Tino Calancha
2018-02-04 3:40 ` Tino Calancha
2018-02-04 12:40 ` Noam Postavsky
2018-02-04 12:47 ` Tino Calancha
2018-02-15 0:09 ` Tino Calancha
2018-02-21 10:18 ` Tino Calancha
2018-02-21 17:47 ` Eli Zaretskii
2018-03-10 8:52 ` Tino Calancha
2018-03-10 10:25 ` Eli Zaretskii
2018-03-10 10:44 ` Tino Calancha
2018-03-10 12:07 ` Eli Zaretskii
2018-03-10 13:17 ` Tino Calancha
2018-03-10 15:50 ` Eli Zaretskii
2018-03-11 11:02 ` Tino Calancha
2018-03-11 17:04 ` Eli Zaretskii
2018-06-20 4:09 ` Noam Postavsky
2018-06-20 16:27 ` Eli Zaretskii
2018-06-20 23:28 ` Noam Postavsky
2018-06-21 1:31 ` Tino Calancha
2018-06-21 2:44 ` Eli Zaretskii [this message]
2018-06-21 3:07 ` Tino Calancha
2018-06-21 19:17 ` Stefan Monnier
2018-06-22 3:34 ` Tino Calancha
2018-06-22 12:44 ` Stefan Monnier
2018-07-18 11:56 ` Noam Postavsky
2018-07-18 12:32 ` Tino Calancha
2018-07-18 14:24 ` Stefan Monnier
2018-07-18 14:56 ` Tino Calancha
2018-07-18 15:54 ` Stefan Monnier
2018-07-18 23:28 ` Tino Calancha
2018-07-19 1:58 ` Stefan Monnier
2018-07-19 2:27 ` Noam Postavsky
2018-07-19 12:45 ` Stefan Monnier
2018-07-20 7:34 ` Tino Calancha
2018-07-19 0:02 ` Noam Postavsky
2018-07-19 2:00 ` Stefan Monnier
2018-07-22 18:33 ` Noam Postavsky
2018-07-22 18:44 ` Eli Zaretskii
2018-07-23 12:22 ` Noam Postavsky
2018-07-23 12:46 ` Stefan Monnier
2018-07-23 12:56 ` Tino Calancha
2018-07-24 0:28 ` Noam Postavsky
2018-07-24 2:35 ` Eli Zaretskii
2018-07-30 1:15 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336xgsvt3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30190@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).