From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32173: 26.1; wdired: broken 'wdired-use-interactive-rename' Date: Fri, 27 Jul 2018 23:59:19 +0300 Message-ID: <8336w4s8d4.fsf@gnu.org> References: <87zhyrfgxu.fsf@delenn.bigo.ensc.de> <83pnzhzo80.fsf@gnu.org> <874lgs984m.fsf@gmx.net> <83va98yero.fsf@gnu.org> <878t64p3az.fsf@gmx.net> <83va91rw7u.fsf@gnu.org> <87zhycmto5.fsf@gmx.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532725090 25298 195.159.176.226 (27 Jul 2018 20:58:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 20:58:10 +0000 (UTC) Cc: 32173@debbugs.gnu.org, enrico.scholz@ensc.de To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 27 22:58:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj9oH-0006NZ-B4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 22:58:01 +0200 Original-Received: from localhost ([::1]:42955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj9qO-0002mT-72 for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 17:00:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj9qI-0002mJ-F8 for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 17:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj9qF-0000e0-EQ for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 17:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fj9qF-0000df-9S for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 17:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fj9qE-00081D-VH for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 17:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 21:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32173 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32173-submit@debbugs.gnu.org id=B32173.153272516930750 (code B ref 32173); Fri, 27 Jul 2018 21:00:02 +0000 Original-Received: (at 32173) by debbugs.gnu.org; 27 Jul 2018 20:59:29 +0000 Original-Received: from localhost ([127.0.0.1]:60612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj9ph-0007zu-C9 for submit@debbugs.gnu.org; Fri, 27 Jul 2018 16:59:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj9pf-0007zh-ME for 32173@debbugs.gnu.org; Fri, 27 Jul 2018 16:59:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj9pX-0008DH-Bh for 32173@debbugs.gnu.org; Fri, 27 Jul 2018 16:59:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj9pX-0008D5-7C; Fri, 27 Jul 2018 16:59:19 -0400 Original-Received: from [176.228.60.248] (port=2440 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fj9pW-0008TC-L9; Fri, 27 Jul 2018 16:59:19 -0400 In-reply-to: <87zhycmto5.fsf@gmx.net> (message from Stephen Berman on Fri, 27 Jul 2018 20:15:38 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149027 Archived-At: > From: Stephen Berman > Cc: enrico.scholz@ensc.de, 32173@debbugs.gnu.org > Date: Fri, 27 Jul 2018 20:15:38 +0200 > > > Thanks. I think we should install your original and safer patch on > > the release branch, and this more thorough fix on master. WDYT? > > Sounds reasonable. Should we give the OP a bit longer to react or > should I just go ahead and commit the fixes (in any case, I may not be > able to until tomorrow or Sunday)? I think by then we will have waited long enough. > I also wrote three tests, two for the bug with non-nil > wdired-use-interactive-rename, one where the edit is finished and one > where it's aborted, and one test for unfinished edits (it might be nice > to have a variant of the latter that uses dired-isearch-filenames, but I > don't see any straightforward way to emulate isearch in the test > environment). The first two tests are suitable for both fixes, but the > third test only succeeds with the fix intended for master, so I use the > :expected-result keyword in the test definition. But should I install > the test file on each branch as part of the commit with the respective > fix (which won't be merged from release to master), or should I make a > separate commit of the test file just to the release branch and let it > be merged to master? You can commit the tests to the emacs-26 branch and let it be merged. Thanks.