* bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection
@ 2018-11-29 16:53 Philipp Stephani
2018-12-01 0:33 ` Paul Eggert
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Stephani @ 2018-11-29 16:53 UTC (permalink / raw)
To: 33547
I didn't manage to reproduce this issue yet, but it seems that
Emacs 26.2 can get stuck in an infinite loop in garbage collection:
(gdb) bt
#0 0x000000000050992c in mark_kboards () at keyboard.c:12020
#1 0x0000000000555f55 in garbage_collect_1 (end=<optimized out>) at alloc.c:5987
#2 0x0000000000555f55 in Fgarbage_collect () at alloc.c:6159
#3 0x000000000056e5e4 in maybe_gc () at lisp.h:4751
#4 0x000000000056e5e4 in Ffuncall (nargs=2, args=args@entry=0x7ffd3b9fbbb0) at eval.c:2809
#5 0x00000000005a95b0 in exec_byte_code (bytestr=<optimized out>, vector=<optimized out>, maxdepth=<optimized out>, args_template=<optimized out>, nargs=nargs@entry=140725603777472, args=<optimized out>,
args@entry=0x17ffd3b9fbdd0) at bytecode.c:630
#6 0x0000000000571041 in funcall_lambda (fun=XIL(0x7ffd3b9fbbb0), nargs=140725603777472, nargs@entry=0, arg_vector=0x17ffd3b9fbdd0, arg_vector@entry=0x7ffd3b9fbdd0) at eval.c:3028
#7 0x000000000056e6eb in Ffuncall (nargs=nargs@entry=1, args=args@entry=0x7ffd3b9fbdc8) at eval.c:2841
#8 0x000000000056e808 in call0 (fn=<optimized out>, fn@entry=XIL(0x7b30)) at eval.c:2670
#9 0x000000000050488b in read_char (commandflag=commandflag@entry=1, map=map@entry=XIL(0xaa1e353), prev_event=XIL(0), used_mouse_menu=used_mouse_menu@entry=0x7ffd3b9fc44b, end_time=end_time@entry=0x0)
at keyboard.c:2619
#10 0x000000000050554c in read_key_sequence
(keybuf=keybuf@entry=0x7ffd3b9fc540, prompt=prompt@entry=XIL(0), dont_downcase_last=dont_downcase_last@entry=false, can_return_switch_frame=can_return_switch_frame@entry=true, fix_current_buffer=fix_current_buffer@entry=true, prevent_redisplay=prevent_redisplay@entry=false, bufsize=30) at keyboard.c:9148
#11 0x0000000000506f84 in command_loop_1 () at keyboard.c:1368
#12 0x000000000056d91e in internal_condition_case (bfun=bfun@entry=0x506d60 <command_loop_1>, handlers=handlers@entry=XIL(0x53d0), hfun=hfun@entry=0x4fdaa0 <cmd_error>) at eval.c:1336
#13 0x00000000004f86b4 in command_loop_2 (ignore=ignore@entry=XIL(0)) at keyboard.c:1110
#14 0x000000000056d88d in internal_catch (tag=tag@entry=XIL(0xccc0), func=func@entry=0x4f8690 <command_loop_2>, arg=arg@entry=XIL(0)) at eval.c:1101
#15 0x00000000004f864b in command_loop () at keyboard.c:1089
#16 0x00000000004fd6b3 in recursive_edit_1 () at keyboard.c:695
#17 0x00000000004fd9ce in Frecursive_edit () at keyboard.c:766
#18 0x000000000041afc3 in main (argc=<optimized out>, argv=0x7ffd3b9fc8e8) at emacs.c:1751
Lisp Backtrace:
"Automatic GC" (0x0)
"vector" (0x3b9fbbb8)
"internal-echo-keystrokes-prefix" (0x3b9fbdd0)
In this situation, Emacs never leaves mark_kboards. The variables here
are:
(gdb) p &kbd_buffer
$7 = (union buffered_input_event (*)[4096]) 0x9a23e0 <kbd_buffer>
(gdb) p ((union buffered_input_event*)kbd_buffer + 4096)
$9 = (union buffered_input_event *) 0x9da3e0 <input_was_pending>
(gdb) p kbd_fetch_ptr
$4 = (union buffered_input_event *) 0x9d9340 <kbd_buffer+225120>
(gdb) p kbd_store_ptr
$5 = (union buffered_input_event * volatile) 0x9a23e0 <kbd_buffer>
(gdb) p event
$6 = (union buffered_input_event *) 0x9ad078 <kbd_buffer+44184>
The loop starts with
for (event = kbd_fetch_ptr; event != kbd_store_ptr; event++)
{
if (event == kbd_buffer + KBD_BUFFER_SIZE)
event = kbd_buffer;
This seems suspicious given that kbd_fetch_ptr > kbd_store_ptr. It
seems like this loop can never terminate, but I don't know how we got
into that situation.
(gdb) bt full
#0 0x000000000050992c in mark_kboards () at keyboard.c:12020
event = 0x9ad078 <kbd_buffer+44184>
kb = <optimized out>
p = <optimized out>
#1 0x0000000000555f55 in garbage_collect_1 (end=<optimized out>) at alloc.c:5987
nextb = <optimized out>
i = <optimized out>
stack_top_variable = 0 '\000'
message_p = false
tot_before = 0
total = {XIL(0), XIL(0x4), XIL(0x7ffd3b9fbd50), XIL(0x5aae61), XIL(0x73de6d), XIL(0xfffffffffe0a3ba0), XIL(0), XIL(0xb7ed375), XIL(0xc660), XIL(0)}
#2 0x0000000000555f55 in Fgarbage_collect () at alloc.c:6159
#3 0x000000000056e5e4 in maybe_gc () at lisp.h:4751
fun = <optimized out>
original_fun = <optimized out>
numargs = 1
val = <optimized out>
count = 4
#4 0x000000000056e5e4 in Ffuncall (nargs=2, args=args@entry=0x7ffd3b9fbbb0) at eval.c:2809
fun = <optimized out>
original_fun = <optimized out>
numargs = 1
val = <optimized out>
count = 4
#5 0x00000000005a95b0 in exec_byte_code (bytestr=<optimized out>, vector=<optimized out>, maxdepth=<optimized out>, args_template=<optimized out>, nargs=nargs@entry=140725603777472, args=<optimized out>,
args@entry=0x17ffd3b9fbdd0) at bytecode.c:630
op = <optimized out>
type = <optimized out>
targets =
{0x5ab9e9 <exec_byte_code+9993>, 0x5a98bd <exec_byte_code+1501>, 0x5a98b8 <exec_byte_code+1496>, 0x5a98b3 <exec_byte_code+1491>, 0x5a96d8 <exec_byte_code+1016>, 0x5a96d8 <exec_byte_code+1016>, 0x5a987d <exec_byte_code+1437>, 0x5a983d <exec_byte_code+1373>, 0x5aa1e6 <exec_byte_code+3846>, 0x5aa20c <exec_byte_code+3884>, 0x5aa207 <exec_byte_code+3879>, 0x5aa202 <exec_byte_code+3874>, 0x5a967f <exec_byte_code+927>, 0x5a9680 <exec_byte_code+928>, 0x5aa3c0 <exec_byte_code+4320>, 0x5aa1eb <exec_byte_code+3851>, 0x5aa294 <exec_byte_code+4020>, 0x5aa28f <exec_byte_code+4015>, 0x5aa28a <exec_byte_code+4010>, 0x5aa285 <exec_byte_code+4005>, 0x5a95ca <exec_byte_code+746>, 0x5a95d0 <exec_byte_code+752>, 0x5aa261 <exec_byte_code+3969>, 0x5aa26e <exec_byte_code+3982>, 0x5aa703 <exec_byte_code+5155>, 0x5aa6fe <exec_byte_code+5150>, 0x5aa6f9 <exec_byte_code+5145>, 0x5aa6f4 <exec_byte_code+5140>, 0x5a9638 <exec_byte_code+856>, 0x5a9640 <exec_byte_code+864>, 0x5aa228 <exec_byte_code+3912>, 0x5aa211 <exec_byte_code+3889>, 0x5aa6cb <exec_byte_code+5099>, 0x5aa6c6 <exec_byte_code+5094>, 0x5aa6c1 <exec_byte_code+5089>, 0x5aa6bc <exec_byte_code+5084>, 0x5a9586 <exec_byte_code+678>, 0x5a9590 <exec_byte_code+688>, 0x5aa6e7 <exec_byte_code+5127>, 0x5aa6d0 <exec_byte_code+5104>, 0x5aa693 <exec_byte_code+5043>, 0x5aa68e <exec_byte_code+5038>, 0x5aa689 <exec_byte_code+5033>, 0x5aa684 <exec_byte_code+5028>, 0x5a9521 <exec_byte_code+577>, 0x5a9528 <exec_byte_code+584>, 0x5aa6af <exec_byte_code+5071>, 0x5aa698 <exec_byte_code+5048>, 0x5ab44e <exec_byte_code+8558>, 0x5ab5d8 <exec_byte_code+8952>, 0x5ab518 <exec_byte_code+8760>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab259 <exec_byte_code+8057>, 0x5ab21a <exec_byte_code+7994>, 0x5ab1d5 <exec_byte_code+7925>, 0x5ab190 <exec_byte_code+7856>, 0x5ab152 <exec_byte_code+7794>, 0x5aa30a <exec_byte_code+4138>, 0x5aa2d1 <exec_byte_code+4081>, 0x5ab125 <exec_byte_code+7749>, 0x5aa34c <exec_byte_code+4204>, 0x5aa299 <exec_byte_code+4025>, 0x5ab0ec <exec_byte_code+7692>, 0x5ab0c3 <exec_byte_code+7651>, 0x5ab08a <exec_byte_code+7594>, 0x5ab057 <exec_byte_code+7543>, 0x5ab024 <exec_byte_code+7492>, 0x5aafb9 <exec_byte_code+7385>, 0x5aaf80 <exec_byte_code+7328>, 0x5aaf43 <exec_byte_code+7267>, 0x5aaf1a <exec_byte_code+7226>, 0x5aaef1 <exec_byte_code+7185>, 0x5aaeb8 <exec_byte_code+7128>, 0x5aae7f <exec_byte_code+7071>, 0x5aae46 <exec_byte_code+7014>, 0x5aae09 <exec_byte_code+6953>, 0x5aadd6 <exec_byte_code+6902>, 0x5aada3 <exec_byte_code+6851>, 0x5aad70 <exec_byte_code+6800>, 0x5aacec <exec_byte_code+6668>, 0x5aacaa <exec_byte_code+6602>, 0x5aac16 <exec_byte_code+6454>, 0x5aabd8 <exec_byte_code+6392>, 0x5aab9a <exec_byte_code+6330>, 0x5aab5c <exec_byte_code+6268>, 0x5aab1e <exec_byte_code+6206>, 0x5aaaeb <exec_byte_code+6155>, 0x5aaaaa <exec_byte_code+6090>, 0x5aaa77 <exec_byte_code+6039>, 0x5aaa44 <exec_byte_code+5988>, 0x5aaa11 <exec_byte_code+5937>, 0x5aa9de <exec_byte_code+5886>, 0x5aa92f <exec_byte_code+5711>, 0x5a9750 <exec_byte_code+1136>, 0x5aa906 <exec_byte_code+5670>, 0x5aa8d8 <exec_byte_code+5624>, 0x5aa853 <exec_byte_code+5491>, 0x5aa810 <exec_byte_code+5424>, 0x5aa7e7 <exec_byte_code+5383>, 0x5aa7bc <exec_byte_code+5340>, 0x5aa791 <exec_byte_code+5297>, 0x5aa75e <exec_byte_code+5246>, 0x5aa733 <exec_byte_code+5203>, 0x5ab9e9 <exec_byte_code+9993>, 0x5aa708 <exec_byte_code+5160>, 0x5a9f9f <exec_byte_code+3263>, 0x5a9f74 <exec_byte_code+3220>, 0x5a9f49 <exec_byte_code+3177>, 0x5a9f1e <exec_byte_code+3134>, 0x5a9ef5 <exec_byte_code+3093>, 0x5a9750 <exec_byte_code+1136>, 0x5ab9e9 <exec_byte_code+9993>, 0x5a9eb6 <exec_byte_code+3030>, 0x5a9e8d <exec_byte_code+2989>, 0x5a9e64 <exec_byte_code+2948>, 0x5aa003 <exec_byte_code+3363>, 0x5a9fca <exec_byte_code+3306>, 0x5a9b20 <exec_byte_code+2112>, 0x5a9aff <exec_byte_code+2079>, 0x5a9ac6 <exec_byte_code+2022>, 0x5a9a8d <exec_byte_code+1965>, 0x5a9a54 <exec_byte_code+1908>, 0x5a9a29 <exec_byte_code+1865>, 0x5a9c9c <exec_byte_code+2492>, 0x5ab9e9 <exec_byte_code+9993>, 0x5aa3fb <exec_byte_code+4379>, 0x5aa632 <exec_byte_code+4946>, 0x5aa384 <exec_byte_code+4260>, 0x5aa5f6 <exec_byte_code+4886>, 0x5aa5c1 <exec_byte_code+4833>, 0x5aa588 <exec_byte_code+4776>, 0x5aa03c <exec_byte_code+3420>, 0x5aa43a <exec_byte_code+4442>, 0x5aa235 <exec_byte_code+3925>, 0x5aa3cd <exec_byte_code+4333>, 0x5ab4a9 <exec_byte_code+8649>, 0x5ab47b <exec_byte_code+8603>, 0x5ab598 <exec_byte_code+8888>, 0x5ab400 <exec_byte_code+8480>, 0x5ab3c3 <exec_byte_code+8419>, 0x5ab37d <exec_byte_code+8349>, 0--Type <RET> for more, q to quit, c to continue without paging--c
x5ab30a <exec_byte_code+8234>, 0x5aa660 <exec_byte_code+4992>, 0x5a9c5f <exec_byte_code+2431>, 0x5a9c36 <exec_byte_code+2390>, 0x5a9c0d <exec_byte_code+2349>, 0x5a9be4 <exec_byte_code+2308>, 0x5a9bbb <exec_byte_code+2267>, 0x5a9b82 <exec_byte_code+2210>, 0x5a9b49 <exec_byte_code+2153>, 0x5a9d90 <exec_byte_code+2736>, 0x5a9d57 <exec_byte_code+2679>, 0x5a9cfe <exec_byte_code+2590>, 0x5a9cc5 <exec_byte_code+2533>, 0x5a9df2 <exec_byte_code+2834>, 0x5a9dc9 <exec_byte_code+2793>, 0x5a9e2b <exec_byte_code+2891>, 0x5a99f0 <exec_byte_code+1808>, 0x5a99b8 <exec_byte_code+1752>, 0x5a9980 <exec_byte_code+1696>, 0x5a994d <exec_byte_code+1645>, 0x5aa9ab <exec_byte_code+5835>, 0x5aa972 <exec_byte_code+5778>, 0x5a9907 <exec_byte_code+1575>, 0x5a98c2 <exec_byte_code+1506>, 0x5ab9e9 <exec_byte_code+9993>, 0x5aa52f <exec_byte_code+4687>, 0x5aa4f8 <exec_byte_code+4632>, 0x5aa4c1 <exec_byte_code+4577>, 0x5aa48d <exec_byte_code+4525>, 0x5aa459 <exec_byte_code+4473>, 0x5aafe2 <exec_byte_code+7426>, 0x5aad2e <exec_byte_code+6734>, 0x5aa896 <exec_byte_code+5558>, 0x5a97fc <exec_byte_code+1308>, 0x5a97af <exec_byte_code+1231>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5a977e <exec_byte_code+1182>, 0x5aa0cd <exec_byte_code+3565>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5ab9e9 <exec_byte_code+9993>, 0x5aa09b <exec_byte_code+3515> <repeats 64 times>}
const_length = <optimized out>
bytestr_length = <optimized out>
vectorp = 0x743010 <pure+829360>
quitcounter = 1 '\001'
stack_items = <optimized out>
sa_avail = <optimized out>
sa_count = <optimized out>
sa_must_free = <optimized out>
stack_base = <optimized out>
stack_lim = <optimized out>
top = 0x7ffd3b9fbbb0
void_stack_lim = <optimized out>
bytestr_data = <optimized out>
pc = <optimized out>
count = <optimized out>
result = <optimized out>
#6 0x0000000000571041 in funcall_lambda (fun=XIL(0x7ffd3b9fbbb0), nargs=140725603777472, nargs@entry=0, arg_vector=0x17ffd3b9fbdd0, arg_vector@entry=0x7ffd3b9fbdd0) at eval.c:3028
val = <optimized out>
syms_left = <optimized out>
lexenv = <optimized out>
i = <optimized out>
optional = <optimized out>
rest = <optimized out>
previous_optional_or_rest = <optimized out>
#7 0x000000000056e6eb in Ffuncall (nargs=nargs@entry=1, args=args@entry=0x7ffd3b9fbdc8) at eval.c:2841
fun = <optimized out>
original_fun = XIL(0x7b30)
numargs = 0
val = <optimized out>
count = 3
#8 0x000000000056e808 in call0 (fn=<optimized out>, fn@entry=XIL(0x7b30)) at eval.c:2670
#9 0x000000000050488b in read_char (commandflag=commandflag@entry=1, map=map@entry=XIL(0xaa1e353), prev_event=XIL(0), used_mouse_menu=used_mouse_menu@entry=0x7ffd3b9fc44b, end_time=end_time@entry=0x0) at keyboard.c:2619
c = <optimized out>
jmpcount = 3
local_getcjmp = {{
__jmpbuf = {44149952, 3937684359170571700, 3, 0, 10326792, 0, 3936423309431456331, -3937681285116542389},
__mask_was_saved = 0,
__saved_mask = {
__val = {93642533, 33264, 59304257, 0, 5655602, 0, 4, 0, 93642528, 6, 0, 1, 140725603778848, 59304257, 0, 0}
}
}}
save_jump = {{
__jmpbuf = {44077824, 0, 65, 140725603770752, -33016736, 5695344, -33130304, 65},
__mask_was_saved = 1000317776,
__saved_mask = {
__val = {65, 0, 140725603770782, 140725603770744, 5936560, 78055685, 4, 48, 96, 1, 210453397508, 0, 0, 472446402651, 0, 0}
}
}}
tem = <optimized out>
save = <optimized out>
previous_echo_area_message = XIL(0)
also_record = XIL(0)
reread = false
recorded = false
polling_stopped_here = false
orig_kboard = 0x3487850
#10 0x000000000050554c in read_key_sequence (keybuf=keybuf@entry=0x7ffd3b9fc540, prompt=prompt@entry=XIL(0), dont_downcase_last=dont_downcase_last@entry=false, can_return_switch_frame=can_return_switch_frame@entry=true, fix_current_buffer=fix_current_buffer@entry=true, prevent_redisplay=prevent_redisplay@entry=false, bufsize=30) at keyboard.c:9148
interrupted_kboard = 0x3487850
interrupted_frame = 0x11d6c30 <bss_sbrk_buffer+8248112>
key = <optimized out>
used_mouse_menu = false
echo_local_start = 0
last_real_key_start = 0
keys_local_start = 0
new_binding = <optimized out>
t = 0
echo_start = 0
keys_start = 0
current_binding = XIL(0xaa1e353)
first_event = XIL(0)
first_unbound = 31
mock_input = 0
fkey = {
parent = XIL(0x10d76d3),
map = XIL(0x10d76d3),
start = 0,
end = 0
}
keytran = {
parent = XIL(0xa63a93),
map = XIL(0xa63a93),
start = 0,
end = 0
}
indec = {
parent = XIL(0x10d7703),
map = XIL(0x10d7703),
start = 0,
end = 0
}
shift_translated = false
delayed_switch_frame = XIL(0)
original_uppercase = XIL(0)
original_uppercase_position = -1
dummyflag = false
fake_prefixed_keys = XIL(0)
#11 0x0000000000506f84 in command_loop_1 () at keyboard.c:1368
cmd = <optimized out>
keybuf = {make_number(80), make_number(52), make_number(98), XIL(0x2a09300), XIL(0x3), XIL(0x56e770), XIL(0x1), XIL(0xaa767c3), XIL(0x7ffd3b9fc610), XIL(0), XIL(0xaa767c3), XIL(0), XIL(0xffffffffffffffff), XIL(0x571cf4), XIL(0xfffffffffe063960), XIL(0xaa767c3), XIL(0x678884), XIL(0), XIL(0), XIL(0x4a6d53413cc7100), XIL(0x7ffd3b9fc610), XIL(0x4fda7f), XIL(0x7ffd3b9fc610), XIL(0), XIL(0), XIL(0x4fdbbf), XIL(0), XIL(0x56e229), XIL(0x5), XIL(0x7b60)}
i = <optimized out>
prev_modiff = 22
prev_buffer = 0x386d23a0
#12 0x000000000056d91e in internal_condition_case (bfun=bfun@entry=0x506d60 <command_loop_1>, handlers=handlers@entry=XIL(0x53d0), hfun=hfun@entry=0x4fdaa0 <cmd_error>) at eval.c:1336
val = <optimized out>
c = 0x33412c0
#13 0x00000000004f86b4 in command_loop_2 (ignore=ignore@entry=XIL(0)) at keyboard.c:1110
val = XIL(0x99)
#14 0x000000000056d88d in internal_catch (tag=tag@entry=XIL(0xccc0), func=func@entry=0x4f8690 <command_loop_2>, arg=arg@entry=XIL(0)) at eval.c:1101
val = <optimized out>
c = 0x33411a0
#15 0x00000000004f864b in command_loop () at keyboard.c:1089
#16 0x00000000004fd6b3 in recursive_edit_1 () at keyboard.c:695
val = <optimized out>
#17 0x00000000004fd9ce in Frecursive_edit () at keyboard.c:766
buffer = <optimized out>
#18 0x000000000041afc3 in main (argc=<optimized out>, argv=0x7ffd3b9fc8e8) at emacs.c:1751
stack_bottom_variable = 0x7f294f292b4b <__libc_calloc+635>
dumping = <optimized out>
skip_args = 0
no_loadup = false
junk = 0x0
dname_arg = 0x0
ch_to_dir = 0x0
original_pwd = <optimized out>
disable_aslr = <optimized out>
rlim = {
rlim_cur = 10022912,
rlim_max = 18446744073709551615
}
sockfd = -1
module_assertions = <optimized out>
Lisp Backtrace:
"Automatic GC" (0x0)
"vector" (0x3b9fbbb8)
"internal-echo-keystrokes-prefix" (0x3b9fbdd0)
(gdb) xbacktrace
"Automatic GC" (0x0)
"vector" (0x3b9fbbb8)
"internal-echo-keystrokes-prefix" (0x3b9fbdd0)
In GNU Emacs 27.0.50 (build 46, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
of 2018-11-27
Repository revision: e02d375cb6670e2306b9c67d7f6fd2dd1d1b2711
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Source file ‘/usr/local/google/home/phst/ThirdParty/emacs-master/lisp/emacs-lisp/bytecomp.el’ newer than byte-compiled file
Eager macro-expansion failure: (wrong-number-of-arguments (2 . 2) 4)
Configured using:
'configure --without-threads --enable-gcc-warnings=warn-only
--enable-gtk-deprecation-warnings --without-pop --with-mailutils
--enable-checking --enable-check-lisp-object-type --with-modules
'CFLAGS=-O0 -ggdb3''
Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS
FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES JSON GMP
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec epa derived epg epg-config
gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst pcase ffap
thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny
seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib
elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)
Memory information:
((conses 16 108712 8519)
(symbols 48 21762 1)
(strings 32 32823 2052)
(string-bytes 1 893166)
(vectors 16 16431)
(vector-slots 8 532238 6552)
(floats 8 52 65)
(intervals 56 221 0)
(buffers 992 12))
--
Google Germany GmbH
Erika-Mann-Straße 33
80636 München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection
2018-11-29 16:53 bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection Philipp Stephani
@ 2018-12-01 0:33 ` Paul Eggert
2018-12-01 8:11 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2018-12-01 0:33 UTC (permalink / raw)
To: Philipp Stephani; +Cc: 33547-done
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
Thanks for reporting that. I installed the first attached patch into
Emacs master and am marking this bug as done. I am not sure whether a
simpler patch should be installed into the emacs-26 branch, but the
second attached patch should do the trick for that if needed, not that
it's easy to test this sort of thing.
[-- Attachment #2: 0001-Fix-infloop-in-GC-mark_kboards-master.patch --]
[-- Type: text/x-patch, Size: 13130 bytes --]
From 7d9fa89fb3f6db0bdc3960bbbf6c0cf34c98d1ca Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 30 Nov 2018 14:22:54 -0800
Subject: [PATCH] Fix infloop in GC mark_kboards
* src/keyboard.c (KBD_BUFFER_SIZE): Now a constant, not a macro.
(kbd_fetch_ptr, kbd_store_ptr): These now always point somewhere
into kbd_buffer, instead of sometimes pointing just past the
end which led to serious bugs (Bug#33547). All uses changed.
(kbd_store_ptr): No longer volatile. This variable has not been
accessed by a signal handler for some time, it seems.
(next_kbd_event, prev_kbd_event): New functions.
(kbd_buffer_nr_stored, process_special_events): Simplify.
---
src/keyboard.c | 181 ++++++++++++++++++++-----------------------------
1 file changed, 72 insertions(+), 109 deletions(-)
diff --git a/src/keyboard.c b/src/keyboard.c
index be727a6549..59acb2dd08 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -92,7 +92,7 @@ volatile int interrupt_input_blocked;
The maybe_quit function checks this. */
volatile bool pending_signals;
-#define KBD_BUFFER_SIZE 4096
+enum { KBD_BUFFER_SIZE = 4096 };
KBOARD *initial_kboard;
KBOARD *current_kboard;
@@ -286,15 +286,11 @@ static bool input_was_pending;
static union buffered_input_event kbd_buffer[KBD_BUFFER_SIZE];
/* Pointer to next available character in kbd_buffer.
- If kbd_fetch_ptr == kbd_store_ptr, the buffer is empty.
- This may be kbd_buffer + KBD_BUFFER_SIZE, meaning that the
- next available char is in kbd_buffer[0]. */
+ If kbd_fetch_ptr == kbd_store_ptr, the buffer is empty. */
static union buffered_input_event *kbd_fetch_ptr;
-/* Pointer to next place to store character in kbd_buffer. This
- may be kbd_buffer + KBD_BUFFER_SIZE, meaning that the next
- character should go in kbd_buffer[0]. */
-static union buffered_input_event *volatile kbd_store_ptr;
+/* Pointer to next place to store character in kbd_buffer. */
+static union buffered_input_event *kbd_store_ptr;
/* The above pair of variables forms a "queue empty" flag. When we
enqueue a non-hook event, we increment kbd_store_ptr. When we
@@ -302,8 +298,7 @@ static union buffered_input_event *volatile kbd_store_ptr;
there is input available if the two pointers are not equal.
Why not just have a flag set and cleared by the enqueuing and
- dequeuing functions? Such a flag could be screwed up by interrupts
- at inopportune times. */
+ dequeuing functions? The code is a bit simpler this way. */
static void recursive_edit_unwind (Lisp_Object buffer);
static Lisp_Object command_loop (void);
@@ -375,6 +370,20 @@ static void deliver_user_signal (int);
static char *find_user_signal_name (int);
static void store_user_signal_events (void);
+/* Advance or retreat a buffered input event pointer. */
+
+static union buffered_input_event *
+next_kbd_event (union buffered_input_event *ptr)
+{
+ return ptr == kbd_buffer + KBD_BUFFER_SIZE - 1 ? kbd_buffer : ptr + 1;
+}
+
+static union buffered_input_event *
+prev_kbd_event (union buffered_input_event *ptr)
+{
+ return ptr == kbd_buffer ? kbd_buffer + KBD_BUFFER_SIZE - 1 : ptr - 1;
+}
+
/* Like EVENT_START, but assume EVENT is an event.
This pacifies gcc -Wnull-dereference, which might otherwise
complain about earlier checks that EVENT is indeed an event. */
@@ -3338,8 +3347,6 @@ readable_events (int flags)
do
{
- if (event == kbd_buffer + KBD_BUFFER_SIZE)
- event = kbd_buffer;
if (!(
#ifdef USE_TOOLKIT_SCROLL_BARS
(flags & READABLE_EVENTS_FILTER_EVENTS) &&
@@ -3356,7 +3363,7 @@ readable_events (int flags)
&& !((flags & READABLE_EVENTS_FILTER_EVENTS)
&& event->kind == BUFFER_SWITCH_EVENT))
return 1;
- event++;
+ event = next_kbd_event (event);
}
while (event != kbd_store_ptr);
}
@@ -3410,12 +3417,8 @@ event_to_kboard (struct input_event *event)
static int
kbd_buffer_nr_stored (void)
{
- return kbd_fetch_ptr == kbd_store_ptr
- ? 0
- : (kbd_fetch_ptr < kbd_store_ptr
- ? kbd_store_ptr - kbd_fetch_ptr
- : ((kbd_buffer + KBD_BUFFER_SIZE) - kbd_fetch_ptr
- + (kbd_store_ptr - kbd_buffer)));
+ int n = kbd_store_ptr - kbd_fetch_ptr;
+ return n + (n < 0 ? KBD_BUFFER_SIZE : 0);
}
#endif /* Store an event obtained at interrupt level into kbd_buffer, fifo */
@@ -3466,12 +3469,10 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event,
(kb, list2 (make_lispy_switch_frame (event->ie.frame_or_window),
make_fixnum (c)));
kb->kbd_queue_has_data = true;
- union buffered_input_event *sp;
- for (sp = kbd_fetch_ptr; sp != kbd_store_ptr; sp++)
- {
- if (sp == kbd_buffer + KBD_BUFFER_SIZE)
- sp = kbd_buffer;
+ for (union buffered_input_event *sp = kbd_fetch_ptr;
+ sp != kbd_store_ptr; sp = next_kbd_event (sp))
+ {
if (event_to_kboard (&sp->ie) == kb)
{
sp->ie.kind = NO_EVENT;
@@ -3516,22 +3517,18 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event,
Just ignore the second one. */
else if (event->kind == BUFFER_SWITCH_EVENT
&& kbd_fetch_ptr != kbd_store_ptr
- && ((kbd_store_ptr == kbd_buffer
- ? kbd_buffer + KBD_BUFFER_SIZE - 1
- : kbd_store_ptr - 1)->kind) == BUFFER_SWITCH_EVENT)
+ && prev_kbd_event (kbd_store_ptr)->kind == BUFFER_SWITCH_EVENT)
return;
- if (kbd_store_ptr - kbd_buffer == KBD_BUFFER_SIZE)
- kbd_store_ptr = kbd_buffer;
-
/* Don't let the very last slot in the buffer become full,
since that would make the two pointers equal,
and that is indistinguishable from an empty buffer.
Discard the event if it would fill the last slot. */
- if (kbd_fetch_ptr - 1 != kbd_store_ptr)
+ union buffered_input_event *next_slot = next_kbd_event (kbd_store_ptr);
+ if (kbd_fetch_ptr != next_slot)
{
*kbd_store_ptr = *event;
- ++kbd_store_ptr;
+ kbd_store_ptr = next_slot;
#ifdef subprocesses
if (kbd_buffer_nr_stored () > KBD_BUFFER_SIZE / 2
&& ! kbd_on_hold_p ())
@@ -3574,11 +3571,8 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event,
void
kbd_buffer_unget_event (struct selection_input_event *event)
{
- if (kbd_fetch_ptr == kbd_buffer)
- kbd_fetch_ptr = kbd_buffer + KBD_BUFFER_SIZE;
-
/* Don't let the very last slot in the buffer become full, */
- union buffered_input_event *kp = kbd_fetch_ptr - 1;
+ union buffered_input_event *kp = prev_kbd_event (kbd_fetch_ptr);
if (kp != kbd_store_ptr)
{
kp->sie = *event;
@@ -3666,12 +3660,9 @@ kbd_buffer_store_help_event (Lisp_Object frame, Lisp_Object help)
void
discard_mouse_events (void)
{
- union buffered_input_event *sp;
- for (sp = kbd_fetch_ptr; sp != kbd_store_ptr; sp++)
+ for (union buffered_input_event *sp = kbd_fetch_ptr;
+ sp != kbd_store_ptr; sp = next_kbd_event (sp))
{
- if (sp == kbd_buffer + KBD_BUFFER_SIZE)
- sp = kbd_buffer;
-
if (sp->kind == MOUSE_CLICK_EVENT
|| sp->kind == WHEEL_EVENT
|| sp->kind == HORIZ_WHEEL_EVENT
@@ -3696,18 +3687,13 @@ discard_mouse_events (void)
bool
kbd_buffer_events_waiting (void)
{
- union buffered_input_event *sp;
-
- for (sp = kbd_fetch_ptr;
- sp != kbd_store_ptr && sp->kind == NO_EVENT;
- ++sp)
- {
- if (sp == kbd_buffer + KBD_BUFFER_SIZE)
- sp = kbd_buffer;
- }
-
- kbd_fetch_ptr = sp;
- return sp != kbd_store_ptr && sp->kind != NO_EVENT;
+ for (union buffered_input_event *sp = kbd_fetch_ptr;
+ ; sp = next_kbd_event (sp))
+ if (sp == kbd_store_ptr || sp->kind != NO_EVENT)
+ {
+ kbd_fetch_ptr = sp;
+ return sp != kbd_store_ptr && sp->kind != NO_EVENT;
+ }
}
\f
@@ -3836,11 +3822,7 @@ kbd_buffer_get_event (KBOARD **kbp,
mouse movement enabled and available. */
if (kbd_fetch_ptr != kbd_store_ptr)
{
- union buffered_input_event *event;
-
- event = ((kbd_fetch_ptr < kbd_buffer + KBD_BUFFER_SIZE)
- ? kbd_fetch_ptr
- : kbd_buffer);
+ union buffered_input_event *event = kbd_fetch_ptr;
*kbp = event_to_kboard (&event->ie);
if (*kbp == 0)
@@ -3861,7 +3843,7 @@ kbd_buffer_get_event (KBOARD **kbp,
since otherwise swallow_events will see it
and process it again. */
struct selection_input_event copy = event->sie;
- kbd_fetch_ptr = event + 1;
+ kbd_fetch_ptr = next_kbd_event (event);
input_pending = readable_events (0);
x_handle_selection_event (©);
#else
@@ -3876,7 +3858,7 @@ kbd_buffer_get_event (KBOARD **kbp,
|| defined (HAVE_NS) || defined (USE_GTK)
case MENU_BAR_ACTIVATE_EVENT:
{
- kbd_fetch_ptr = event + 1;
+ kbd_fetch_ptr = next_kbd_event (event);
input_pending = readable_events (0);
if (FRAME_LIVE_P (XFRAME (event->ie.frame_or_window)))
x_activate_menubar (XFRAME (event->ie.frame_or_window));
@@ -3921,7 +3903,7 @@ kbd_buffer_get_event (KBOARD **kbp,
case SELECT_WINDOW_EVENT:
{
obj = make_lispy_event (&event->ie);
- kbd_fetch_ptr = event + 1;
+ kbd_fetch_ptr = next_kbd_event (event);
}
break;
default:
@@ -3975,7 +3957,7 @@ kbd_buffer_get_event (KBOARD **kbp,
/* Wipe out this event, to catch bugs. */
clear_event (&event->ie);
- kbd_fetch_ptr = event + 1;
+ kbd_fetch_ptr = next_kbd_event (event);
}
}
}
@@ -4042,17 +4024,9 @@ kbd_buffer_get_event (KBOARD **kbp,
static void
process_special_events (void)
{
- union buffered_input_event *event;
-
- for (event = kbd_fetch_ptr; event != kbd_store_ptr; ++event)
+ for (union buffered_input_event *event = kbd_fetch_ptr;
+ event != kbd_store_ptr; event = next_kbd_event (event))
{
- if (event == kbd_buffer + KBD_BUFFER_SIZE)
- {
- event = kbd_buffer;
- if (event == kbd_store_ptr)
- break;
- }
-
/* If we find a stored X selection request, handle it now. */
if (event->kind == SELECTION_REQUEST_EVENT
|| event->kind == SELECTION_CLEAR_EVENT)
@@ -4066,28 +4040,21 @@ process_special_events (void)
cyclically. */
struct selection_input_event copy = event->sie;
- union buffered_input_event *beg
- = (kbd_fetch_ptr == kbd_buffer + KBD_BUFFER_SIZE)
- ? kbd_buffer : kbd_fetch_ptr;
+ int moved_events;
- if (event > beg)
- memmove (beg + 1, beg, (event - beg) * sizeof *beg);
- else if (event < beg)
+ if (event < kbd_fetch_ptr)
{
- if (event > kbd_buffer)
- memmove (kbd_buffer + 1, kbd_buffer,
- (event - kbd_buffer) * sizeof *kbd_buffer);
- *kbd_buffer = *(kbd_buffer + KBD_BUFFER_SIZE - 1);
- if (beg < kbd_buffer + KBD_BUFFER_SIZE - 1)
- memmove (beg + 1, beg,
- (kbd_buffer + KBD_BUFFER_SIZE - 1 - beg) * sizeof *beg);
+ memmove (kbd_buffer + 1, kbd_buffer,
+ (event - kbd_buffer) * sizeof *kbd_buffer);
+ kbd_buffer[0] = kbd_buffer[KBD_BUFFER_SIZE - 1];
+ moved_events = kbd_buffer + KBD_BUFFER_SIZE - 1 - kbd_fetch_ptr;
}
-
- if (kbd_fetch_ptr == kbd_buffer + KBD_BUFFER_SIZE)
- kbd_fetch_ptr = kbd_buffer + 1;
else
- kbd_fetch_ptr++;
+ moved_events = event - kbd_fetch_ptr;
+ memmove (kbd_fetch_ptr + 1, kbd_fetch_ptr,
+ moved_events * sizeof *kbd_fetch_ptr);
+ kbd_fetch_ptr = next_kbd_event (kbd_fetch_ptr);
input_pending = readable_events (0);
x_handle_selection_event (©);
#else
@@ -10261,11 +10228,10 @@ stuff_buffered_input (Lisp_Object stuffstring)
rms: we should stuff everything back into the kboard
it came from. */
- for (; kbd_fetch_ptr != kbd_store_ptr; kbd_fetch_ptr++)
+ for (; kbd_fetch_ptr != kbd_store_ptr;
+ kbd_fetch_ptr = next_kbd_event (kbd_fetch_ptr))
{
- if (kbd_fetch_ptr == kbd_buffer + KBD_BUFFER_SIZE)
- kbd_fetch_ptr = kbd_buffer;
if (kbd_fetch_ptr->kind == ASCII_KEYSTROKE_EVENT)
stuff_char (kbd_fetch_ptr->ie.code);
@@ -12003,21 +11969,18 @@ mark_kboards (void)
mark_object (KVAR (kb, echo_string));
mark_object (KVAR (kb, echo_prompt));
}
- {
- union buffered_input_event *event;
- for (event = kbd_fetch_ptr; event != kbd_store_ptr; event++)
- {
- if (event == kbd_buffer + KBD_BUFFER_SIZE)
- event = kbd_buffer;
- /* These two special event types has no Lisp_Objects to mark. */
- if (event->kind != SELECTION_REQUEST_EVENT
- && event->kind != SELECTION_CLEAR_EVENT)
- {
- mark_object (event->ie.x);
- mark_object (event->ie.y);
- mark_object (event->ie.frame_or_window);
- mark_object (event->ie.arg);
- }
- }
- }
+
+ for (union buffered_input_event *event = kbd_fetch_ptr;
+ event != kbd_store_ptr; event = next_kbd_event (event))
+ {
+ /* These two special event types have no Lisp_Objects to mark. */
+ if (event->kind != SELECTION_REQUEST_EVENT
+ && event->kind != SELECTION_CLEAR_EVENT)
+ {
+ mark_object (event->ie.x);
+ mark_object (event->ie.y);
+ mark_object (event->ie.frame_or_window);
+ mark_object (event->ie.arg);
+ }
+ }
}
--
2.19.2
[-- Attachment #3: 0001-Fix-infloop-in-GC-mark_kboards-emacs-26.patch --]
[-- Type: text/x-patch, Size: 972 bytes --]
From 7df217da0c97702988aadb6b231067a8bcda1703 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 30 Nov 2018 14:14:18 -0800
Subject: [PATCH] Fix infloop in GC mark_kboards
Do not merge to master, as I have a more systematic fix there.
* src/keyboard.c (mark_kboards): Fix infloop (Bug#33547).
---
src/keyboard.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/keyboard.c b/src/keyboard.c
index 0d56ea3f7a..dccc6b7f12 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -12011,7 +12011,12 @@ mark_kboards (void)
for (event = kbd_fetch_ptr; event != kbd_store_ptr; event++)
{
if (event == kbd_buffer + KBD_BUFFER_SIZE)
- event = kbd_buffer;
+ {
+ event = kbd_buffer;
+ if (event == kbd_store_ptr)
+ break;
+ }
+
/* These two special event types has no Lisp_Objects to mark. */
if (event->kind != SELECTION_REQUEST_EVENT
&& event->kind != SELECTION_CLEAR_EVENT)
--
2.19.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection
2018-12-01 0:33 ` Paul Eggert
@ 2018-12-01 8:11 ` Eli Zaretskii
2018-12-01 21:46 ` Paul Eggert
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-12-01 8:11 UTC (permalink / raw)
To: Paul Eggert; +Cc: p.stephani2, eggert, 33547
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 30 Nov 2018 16:33:16 -0800
> Cc: 33547-done@debbugs.gnu.org
>
> Thanks for reporting that. I installed the first attached patch into
> Emacs master and am marking this bug as done. I am not sure whether a
> simpler patch should be installed into the emacs-26 branch, but the
> second attached patch should do the trick for that if needed, not that
> it's easy to test this sort of thing.
If the simplified change indeed fixes the infloop, I'm okay with
having it on emacs-26.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection
2018-12-01 8:11 ` Eli Zaretskii
@ 2018-12-01 21:46 ` Paul Eggert
0 siblings, 0 replies; 4+ messages in thread
From: Paul Eggert @ 2018-12-01 21:46 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: p.stephani2, 33547
Eli Zaretskii wrote:
> If the simplified change indeed fixes the infloop, I'm okay with
> having it on emacs-26.
OK, I installed it there. Although I did not reproduce the bug in the wild, the
symptoms are clear and the fix is obviously correct. Plus, even if I'm wrong
(which I'm not :-), the fix does not hurt anything.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-01 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29 16:53 bug#33547: 27.0.50; Emacs stuck in infinite loop in garbage collection Philipp Stephani
2018-12-01 0:33 ` Paul Eggert
2018-12-01 8:11 ` Eli Zaretskii
2018-12-01 21:46 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).