From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, 28691@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691)
Date: Mon, 17 Dec 2018 21:58:26 +0200 [thread overview]
Message-ID: <8336qwdixp.fsf@gnu.org> (raw)
In-Reply-To: <20181217192011.17783-1-phst@google.com> (message from Philipp Stephani on Mon, 17 Dec 2018 20:20:11 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 17 Dec 2018 20:20:11 +0100
> Cc: Philipp Stephani <phst@google.com>
>
> +@item :file-handler @var{file-handler}
> +If @var{file-handler} is non-@code{nil}, then look for a file name
> +handler for the current buffer's @code{default-directory}
... and invoke that file handler to make the process.
> + If there
> +is no such handler, proceed as if @var{file-handler} were nil.
^^^
That "nil" should be in @code.
> +** 'make-process' now takes a keyword argument ':file-handler'; if
> +that is non-nil, it will look for a file name handler for the current
> +buffer's 'default-directory'.
Likewise.
> +:file-handler FILE-HANDLER -- If FILE-HANDLER is non-nil, then look
> +for a file name handler for the current buffer's `default-directory'.
Likewise.
> + (skip-unless (file-accessible-directory-p "/:/bin/"))
I don't see why we should skip important tests on platforms where
there's no /bin. Isn't it possible to use the Emacs binary here (and
elsewhere in the tests you add), as I suggested?
Thanks.
next prev parent reply other threads:[~2018-12-17 19:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 17:13 bug#28691: 27.0.50; make-process has no file-name-handler Stefan Monnier
2017-10-03 17:50 ` Michael Albinus
2017-10-03 18:34 ` Eli Zaretskii
2018-12-16 23:39 ` bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Philipp Stephani
2018-12-17 12:38 ` Michael Albinus
2018-12-17 17:35 ` Eli Zaretskii
2018-12-17 19:07 ` Philipp Stephani
[not found] ` <838t0odpk8.fsf@gnu.org>
2018-12-17 19:30 ` Michael Albinus
[not found] ` <CAArVCkSzt=pcVG9ZRpdT6oSi30ExcqBGAQ5J8b3x0+gkOo+d2w@mail.gmail.com>
2018-12-17 19:20 ` Philipp Stephani
2018-12-17 19:58 ` Eli Zaretskii [this message]
2018-12-17 20:47 ` Philipp Stephani
2018-12-22 9:07 ` Eli Zaretskii
2018-12-22 9:31 ` Michael Albinus
2018-12-22 21:08 ` Philipp Stephani
2018-12-23 7:41 ` Michael Albinus
2018-12-23 10:08 ` Philipp Stephani
2018-12-23 10:26 ` Michael Albinus
2018-12-23 15:45 ` Eli Zaretskii
2018-12-23 16:36 ` Michael Albinus
2018-12-23 16:50 ` Eli Zaretskii
2018-12-22 22:26 ` Philipp Stephani
2018-12-17 19:33 ` Michael Albinus
2018-12-17 20:03 ` Drew Adams
[not found] ` <20181216233936.208568-1-phst@google.com>
2018-12-17 17:34 ` Eli Zaretskii
[not found] ` <mailman.5866.1545079749.1284.bug-gnu-emacs@gnu.org>
2018-12-18 1:57 ` Alan Mackenzie
2018-12-18 7:56 ` Michael Albinus
2018-12-22 21:05 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336qwdixp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28691@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).