From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Date: Sat, 13 Jul 2019 16:24:56 +0300 Message-ID: <8336ja12zb.fsf@gnu.org> References: <83r26u1jeu.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49412"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20150@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 15:26:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmI2Y-000CU9-N7 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 15:26:14 +0200 Original-Received: from localhost ([::1]:55362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmI2S-000071-Ir for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 09:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52097) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmI2P-00006j-1o for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:26:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmI2O-00087I-7a for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:26:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmI2O-00087C-45 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:26:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmI2N-0002Wf-RW for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 09:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20150-submit@debbugs.gnu.org id=B20150.15630243279662 (code B ref 20150); Sat, 13 Jul 2019 13:26:02 +0000 Original-Received: (at 20150) by debbugs.gnu.org; 13 Jul 2019 13:25:27 +0000 Original-Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmI1n-0002Vl-5W for submit@debbugs.gnu.org; Sat, 13 Jul 2019 09:25:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmI1l-0002VX-J4 for 20150@debbugs.gnu.org; Sat, 13 Jul 2019 09:25:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmI1f-0007bq-Uy; Sat, 13 Jul 2019 09:25:20 -0400 Original-Received: from [176.228.60.248] (port=1506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmI1Q-0002hy-VJ; Sat, 13 Jul 2019 09:25:08 -0400 In-reply-to: (message from Stefan Kangas on Sat, 13 Jul 2019 15:09:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162876 Archived-At: > From: Stefan Kangas > Date: Sat, 13 Jul 2019 15:09:39 +0200 > Cc: 20150@debbugs.gnu.org > > > Hmm... we declare a non-internal variable obsolete and replace it with > > an internal variable? Why is that a good idea? Does the new variable > > have to be internal? > > I thought about it a bit more, and I guess it doesn't have to be internal. I > suggest that the new variable should be kept internal for now though. You mean, it doesn't have to be obsolete? > I also don't know why I named the new variable bookmark-annotation--name, so > I've changed that to bookmark--annotation-name to better reflect current > practices. Hmm... I don't see bookmark--annotation-name in the patch. Did you send the correct patch?