From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32510: xref-find-definitions should return file names, too Date: Thu, 18 Jul 2019 19:07:50 +0300 Message-ID: <8336j3wckp.fsf@gnu.org> References: <83a7dbweyg.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28534"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 32510@debbugs.gnu.org To: Ludovic Brenta Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 18 18:09:06 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ho8xu-0007LN-D4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 18:09:06 +0200 Original-Received: from localhost ([::1]:39686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho8xt-0002et-Ec for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jul 2019 12:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60713) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho8xq-0002bd-QO for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 12:09:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho8xp-0001tL-Te for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 12:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ho8xp-0001tE-QE for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 12:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ho8xp-000737-Jg for bug-gnu-emacs@gnu.org; Thu, 18 Jul 2019 12:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346608326998 (code B ref 32510); Thu, 18 Jul 2019 16:09:01 +0000 Original-Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 16:08:03 +0000 Original-Received: from localhost ([127.0.0.1]:54569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8wt-00071F-4u for submit@debbugs.gnu.org; Thu, 18 Jul 2019 12:08:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8wr-00070f-UR for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 12:08:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ho8wm-0001AF-C7; Thu, 18 Jul 2019 12:07:56 -0400 Original-Received: from [176.228.60.248] (port=1638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ho8wl-0002X6-MK; Thu, 18 Jul 2019 12:07:56 -0400 In-reply-to: (message from Ludovic Brenta on Thu, 18 Jul 2019 17:54:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163318 Archived-At: > Date: Thu, 18 Jul 2019 17:54:59 +0200 > From: Ludovic Brenta > > Yes, this is exactly what happens. We have thousands of source files > in our tree and most have names longer than 20 characters. Our normal > usage pattern is to use partial matching. Also your patch uses > tag-partial-file-name-match-p, not tag-full-file-name-match-p, so > it's not surprising that it should do partial matching with possibly > more than one match :) > > With etags we were used to using "C-u M-." a couple times too, or > start over with a longer substring of the file name we wanted. > > I'm not complaining about this new behavior; it will just take a > little getting used to. Personally I like the fact that M-g M-n > works with the *xref* buffer like it does in a *compilation* buffer. OK, so I hope Dmitry will approve the change. Thanks.