From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 20153@debbugs.gnu.org, ohwoeowho@gmail.com
Subject: bug#20153: 24.4.91; destructive add-face-text-property and string deep copying
Date: Wed, 09 Oct 2019 21:06:54 +0300 [thread overview]
Message-ID: <8336g1vlmp.fsf@gnu.org> (raw)
In-Reply-To: <871rvl95il.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 09 Oct 2019 19:45:54 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: ohwoeowho@gmail.com, 20153@debbugs.gnu.org
> Date: Wed, 09 Oct 2019 19:45:54 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Instead I've now changed add_properties (and add_text_properties_1) to
> >> take a bool parameter to say whether they're allowed to be destructive
> >> or not, and make the add-face-text-property call that with false as the
> >> parameter if the object is a string. This fixes the test case for me
> >> and should hopefully have no measurable performance impact.
> >
> > Isn't that a backward-incompatible change?
>
> It is, but the previous behaviour was a bug. If you have a copy of a
> string and modify the copy, the original string shouldn't change.
AFAIU, the string didn't change, only its plist did. Right?
Please bring this up on emacs-devel, and if no one objects to the
change, we should at least mention it in NEWS.
Thanks.
next prev parent reply other threads:[~2019-10-09 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 12:28 bug#20153: 24.4.91; destructive add-face-text-property and string deep copying Oleh Krehel
2019-10-09 2:25 ` Lars Ingebrigtsen
2019-10-09 3:04 ` Lars Ingebrigtsen
2019-10-09 8:24 ` Oleh Krehel
2019-10-09 17:10 ` Eli Zaretskii
2019-10-09 17:45 ` Lars Ingebrigtsen
2019-10-09 18:06 ` Eli Zaretskii [this message]
2019-10-09 18:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336g1vlmp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20153@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).