From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el Date: Sun, 20 Oct 2019 18:05:31 +0300 Message-ID: <8336fn5uf8.fsf@gnu.org> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> <20191020143930.ugxiakrap7yym6qw@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48603"; mail-complaints-to="usenet@blaine.gmane.org" Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 17:07:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMCnX-000CRu-Q1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 17:07:11 +0200 Original-Received: from localhost ([::1]:37606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMCnW-00060G-1v for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 11:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53846) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMCnP-000607-Kz for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMCnO-0007F7-LV for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMCnO-0007F2-Ii for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMCnO-0002vO-Cj for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37806 X-GNU-PR-Package: emacs Original-Received: via spool by 37806-submit@debbugs.gnu.org id=B37806.157158396711166 (code B ref 37806); Sun, 20 Oct 2019 15:07:02 +0000 Original-Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 15:06:07 +0000 Original-Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCmV-0002u2-GK for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:06:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMCmT-0002tX-PG for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 11:06:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMCmO-0006kE-9y; Sun, 20 Oct 2019 11:06:00 -0400 Original-Received: from [176.228.60.248] (port=2231 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMCm7-0007rS-2O; Sun, 20 Oct 2019 11:05:50 -0400 In-reply-to: <20191020143930.ugxiakrap7yym6qw@Ergus> (message from Ergus on Sun, 20 Oct 2019 16:39:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169823 Archived-At: > Date: Sun, 20 Oct 2019 16:39:30 +0200 > From: Ergus > Cc: Eli Zaretskii , 37806@debbugs.gnu.org > > The proper fix must be to declare the vector in the C side using the > real symbols like: > > Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = { > Qnil QCfamily, QCfoundry, QCwidth QCheight, > QCweight, QCslant, QCunderline, QCinverse_video, > QCforeground, QCbackground, QCstipple, QCoverline, > QCstrike_through, QCbox, QCfont, QCinherit, QCfontset, > QCdistant_foreground, QCextend > }; > > But using makevector or a similar api from C. Yes, and face-remap.el even says so. You can "steal" the way this is done from coding.c, starting around line 11635 (but there should be no need to staticpro a variable that is visible from Lisp, unlike Vcoding_category_table). Thanks.