From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37874: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Date: Wed, 23 Oct 2019 20:58:15 +0300 Message-ID: <8336fjz6mg.fsf@gnu.org> References: <83wodj4lab.fsf@gnu.org> <86muejsert.fsf@gmail.com> <87a79rxx5y.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99346"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37874@debbugs.gnu.org, 37578@debbugs.gnu.org, politza@hochschule-trier.de To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 20:37:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNLVN-000Pch-VT for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 20:37:10 +0200 Original-Received: from localhost ([::1]:43576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNLVM-0004xE-LI for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 14:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNKuY-00085T-56 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 13:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNKuW-00074F-6k for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 13:59:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54389) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNKuV-00073q-1W for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 13:59:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNKuU-0008Uy-Vb for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 13:59:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37874 X-GNU-PR-Package: emacs Original-Received: via spool by 37874-submit@debbugs.gnu.org id=B37874.157185353732643 (code B ref 37874); Wed, 23 Oct 2019 17:59:02 +0000 Original-Received: (at 37874) by debbugs.gnu.org; 23 Oct 2019 17:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:34974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKuP-0008UP-70 for submit@debbugs.gnu.org; Wed, 23 Oct 2019 13:58:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKuK-0008U0-Cs; Wed, 23 Oct 2019 13:58:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNKuB-0006sa-Vh; Wed, 23 Oct 2019 13:58:44 -0400 Original-Received: from [176.228.60.248] (port=2636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iNKu2-0006wP-AF; Wed, 23 Oct 2019 13:58:35 -0400 In-reply-to: <87a79rxx5y.fsf@gnu.org> (message from Tassilo Horn on Wed, 23 Oct 2019 18:07:53 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170088 Archived-At: > From: Tassilo Horn > Cc: ynyaaa@gmail.com, 37578@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 23 Oct 2019 18:07:53 +0200 > > > image-mode.el was scrolling images vertically in units of canonical > > character height, so it couldn't handle the last portion of an image > > smaller than the height of one character. > > > > This is now fixed on the master branch. > > Your change 9c66b09950cf2db50eb6d818656a268ef750bfe6 broke doc-view.el > and the pdf-tools package whose author already filed bug#37874 for the > issue. > > Could you have a look? If the image functions stay returning pixel > values that's ok but Andreas and I will need to adapt pdf-tools and > doc-view.el accordingly. Sorry, I didn't think some other package will use that function, it looked like an internal subroutine. I should have checked. To answer your question: I see no reason to go back to character units in this function. We could either adapt the other packages to the change, or add a new function that will work like the previous image-next-line. What would you prefer? If the only problem is with comparing against the value returned by window-vscroll, then perhaps the former is easier and simpler? Thanks.