From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Fri, 06 Dec 2019 18:18:41 +0200 Message-ID: <8336dxh1ge.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194792"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 06 18:16:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idHDs-000oTN-GF for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 18:16:56 +0100 Original-Received: from localhost ([::1]:41696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idHDr-00083E-74 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 12:16:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idGK0-0005ra-5h for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idGJw-00037p-Sm for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idGJp-000358-VO for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idGJp-0005Cc-PJ for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 11:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Dec 2019 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157564913119975 (code B ref 37774); Fri, 06 Dec 2019 16:19:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 6 Dec 2019 16:18:51 +0000 Original-Received: from localhost ([127.0.0.1]:46945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGJf-0005C7-0o for submit@debbugs.gnu.org; Fri, 06 Dec 2019 11:18:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGJd-0005Bu-Jr for 37774@debbugs.gnu.org; Fri, 06 Dec 2019 11:18:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idGJX-0002s2-D0; Fri, 06 Dec 2019 11:18:43 -0500 Original-Received: from [176.228.60.248] (port=4448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idGJV-0005QP-V1; Fri, 06 Dec 2019 11:18:43 -0500 In-reply-to: <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> (message from Dmitry Gutov on Fri, 6 Dec 2019 17:44:33 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172950 Archived-At: > Cc: 37774@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Fri, 6 Dec 2019 17:44:33 +0200 > > It's great that you mentioned face-spec-recalc. It looks just like the > place to change, since both defface and theme definitions and > customizations go through it. > > We can implement in there a new kind of "face spec" along the lines of > my previous description, or simply special-case the :extend attribute, > and take it from the default spec. The latter option is implemented in > the attached patch, which seems to work in my limited testing. Thanks, but is it clean enough to do such exemption for :extend? And if we want to do this, why do it in face-spec-recalc and not in custom-set-faces itself? The latter will not risk producing unintended consequences for callers of face-spec-recalc other than custom-set-faces. > - ;; defface spec entirely (rather than inheriting from it). If > - ;; there was no spec applicable to FRAME, apply the defface spec > - ;; as well as any applicable X resources. > + ;; defface spec entirely rather than inheriting from it, with the > + ;; exception of the :extend attribute (which is inherited). You slightly modified the syntax of the comment, probably a typo. > + (when (and theme-face-applied (not themed-extend-attr)) > + (let ((extend-p (plist-get default-attrs :extend))) > + (and extend-p (face-spec-set-2 face frame '(:extend t))))) ^^^^^^^^^^^^ I think this should be extend-p instead, because the face's default spec could legitimately say ":extend nil". Right?