From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error Date: Sun, 12 Apr 2020 17:42:11 +0300 Message-ID: <833698lq9o.fsf@gnu.org> References: <83v9m7n98j.fsf@gnu.org> <83r1wvmt7k.fsf@gnu.org> <83ftdbmjan.fsf@gnu.org> <837dyklszu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 16:43:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNdpG-000Lfx-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 16:43:10 +0200 Original-Received: from localhost ([::1]:34072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdpF-0006IJ-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 10:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35059) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdp9-0006IA-Kl for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:43:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNdp8-0005pO-KC for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47106) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNdp8-0005pH-H0 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNdp8-0002GC-F9 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40529 X-GNU-PR-Package: emacs Original-Received: via spool by 40529-submit@debbugs.gnu.org id=B40529.15867025508646 (code B ref 40529); Sun, 12 Apr 2020 14:43:02 +0000 Original-Received: (at 40529) by debbugs.gnu.org; 12 Apr 2020 14:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:58652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdob-0002FO-Ml for submit@debbugs.gnu.org; Sun, 12 Apr 2020 10:42:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdoa-0002FB-3f for 40529@debbugs.gnu.org; Sun, 12 Apr 2020 10:42:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNdoU-0005by-T8; Sun, 12 Apr 2020 10:42:22 -0400 Original-Received: from [176.228.60.248] (port=3681 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNdoU-0003fi-Bv; Sun, 12 Apr 2020 10:42:22 -0400 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sun, 12 Apr 2020 15:13:35 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178251 Archived-At: > From: João Távora > Date: Sun, 12 Apr 2020 15:13:35 +0100 > Cc: Aidan Beggs , 40529@debbugs.gnu.org > > I don't remember all the callers/users of tabulated-list-mode, so I > cannot be sure your patch is correct. (Why only update the header? > the columns below the header need to be realigned as well, no? See > tabulated-line-print-col, for example.) > > I don't know what you are calling attention to in that function. Can > you be more specific? AFAIR, the :align-to display spec needs to be recalculated when line numbers are turned on or off. > Furthermore I think it is a regression in itself to deliver an Emacs > 27 with this changed tabulated-list-mode bootstrapping behaviour. Maybe so, but that code endured many months on the master branch and then in the pretest, so we have some reason to believe it is correct. The code was introduced to solve real problems in some users of tabulated-list-mode (and we have quite a few of them in core alone). > However, if you are convinced it's TRT, I'm okay with doing that on > master. On the release branch, please try to find a solution that is > not in tabulated-list-mode, but in Flymake. > > I tried around a bit and couldn't come up with anything that I know is > safe, short of some very ugly vapourware hacks. Not saying that it > doesn't exist, but I started searching in tabulated-list-mode and > I do think that's the best place to fix it. Like I said: making changes in tabulated-list-mode is too risky at this point for the release branch. I'm sure a simple solution for Flymake can be found. E.g., what about skipping the entire body of flymake--diagnostics-buffer-entries if flymake--diagnostics-buffer-source is nil?