From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40693: 28.0.50; json-encode-alist changes alist Date: Wed, 29 Apr 2020 17:40:04 +0300 Message-ID: <83368mz77f.fsf@gnu.org> References: <87a738jotd.fsf@tcd.ie> <87mu6utxd1.fsf@tcd.ie> <83r1w6ziql.fsf@gnu.org> <82572c3f-fb24-0b01-06ec-47067d9219ca@yandex.ru> <83blnazdly.fsf@gnu.org> <349d9b1b-4659-907e-c6e1-30cdf052c87f@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62765"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, darthandrus@gmail.com, 40693@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 29 16:44:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTnwc-000GCj-7Y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 16:44:14 +0200 Original-Received: from localhost ([::1]:41970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTnwa-0000YC-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 10:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTnvz-0000Uu-Pe for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 10:44:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTntW-0007OX-PT for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 10:43:35 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTntW-0007Me-E3 for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 10:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTntW-00086A-Bp for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2020 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40693 X-GNU-PR-Package: emacs Original-Received: via spool by 40693-submit@debbugs.gnu.org id=B40693.158817123431087 (code B ref 40693); Wed, 29 Apr 2020 14:41:02 +0000 Original-Received: (at 40693) by debbugs.gnu.org; 29 Apr 2020 14:40:34 +0000 Original-Received: from localhost ([127.0.0.1]:44209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTnt4-00085K-8P for submit@debbugs.gnu.org; Wed, 29 Apr 2020 10:40:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTnt2-000856-Mt for 40693@debbugs.gnu.org; Wed, 29 Apr 2020 10:40:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56362) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTnsx-0006vw-1b; Wed, 29 Apr 2020 10:40:27 -0400 Original-Received: from [176.228.60.248] (port=4408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTnsw-0002mK-77; Wed, 29 Apr 2020 10:40:26 -0400 In-Reply-To: <349d9b1b-4659-907e-c6e1-30cdf052c87f@yandex.ru> (message from Dmitry Gutov on Wed, 29 Apr 2020 17:28:05 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179312 Archived-At: > Cc: contovob@tcd.ie, darthandrus@gmail.com, 40693@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 29 Apr 2020 17:28:05 +0300 > > > How about adding an optional argument instead, by default off, to > > request this behavior? then callers who care about the original alist > > could request a non-destructive operation, and others won't suffer any > > slowdown. > > The current behavior is unsafe, that's the problem. Also, > json-encode-alist is called in a recursive fashion, so it'd have to be a > global variable instead. Sounds like a somewhat hairy issue. Then let's put this on master first. If this turns out to be a very popular change, and no one complains, we could later back-port it to some 27.x version. Thanks.