From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25987: 25.2; support gcc fixit notes Date: Tue, 13 Oct 2020 17:37:54 +0300 Message-ID: <83362i2nul.fsf@gnu.org> References: <87lgsj1jle.fsf@tromey.com> <1521218887.2913.237.camel@redhat.com> <83muz7pyde.fsf@gnu.org> <83o8lf9p68.fsf@gnu.org> <26f277bb345f10efe6340ac4074960905064fc97.camel@redhat.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14790"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 25987@debbugs.gnu.org To: David Malcolm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 13 16:38:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSLRM-0003kR-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 16:38:12 +0200 Original-Received: from localhost ([::1]:43606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLRL-0005E7-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 10:38:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSLRE-0005Dp-Tw for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 10:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSLRB-0002ps-Ue for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 10:38:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSLRB-0005up-SV for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 10:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2020 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25987 X-GNU-PR-Package: emacs Original-Received: via spool by 25987-submit@debbugs.gnu.org id=B25987.160259987522725 (code B ref 25987); Tue, 13 Oct 2020 14:38:01 +0000 Original-Received: (at 25987) by debbugs.gnu.org; 13 Oct 2020 14:37:55 +0000 Original-Received: from localhost ([127.0.0.1]:48129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSLR5-0005uS-Fy for submit@debbugs.gnu.org; Tue, 13 Oct 2020 10:37:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSLR3-0005u3-Hg for 25987@debbugs.gnu.org; Tue, 13 Oct 2020 10:37:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36478) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLQx-0002nJ-1z; Tue, 13 Oct 2020 10:37:47 -0400 Original-Received: from [176.228.60.248] (port=2109 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSLQw-0003Zf-H1; Tue, 13 Oct 2020 10:37:46 -0400 In-Reply-To: <26f277bb345f10efe6340ac4074960905064fc97.camel@redhat.com> (message from David Malcolm on Mon, 12 Oct 2020 18:27:29 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190422 Archived-At: > From: David Malcolm > Cc: 25987@debbugs.gnu.org > Date: Mon, 12 Oct 2020 18:27:29 -0400 > > I like how -fdiagnostics-parseable-fixits adds extra lines of output, > with a prefix that's ought to be easy to detect. Yes, I think that's preferable, indeed. > BTW, does Emacs set anything in the environment that GCC could detect? Yes, Emacs sets INSIDE_EMACS when it runs a sub-process. > Does Emacs have an automated test suite that could test this feature? Yes, see the tests in the test/ subdirectory of the Emacs tree. > Another complication to consider: the locations in a fix-it hint refer > to the original source file, before any changes are made. If the user > interface supports the user e.g. clicking on fix-it hints and > selectively apply them one by one, then after each fix-it hint is > applied, all locations after that point potentially need to be "fixed > up" somehow, to reflect the changes to the buffer. That could be handled automatically by defining a marker at each hint's location, then they will move as text is edited.