unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: sbaugh@catern.com, 44638@debbugs.gnu.org
Subject: bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors
Date: Wed, 02 Dec 2020 17:41:28 +0200	[thread overview]
Message-ID: <83360ogqqf.fsf@gnu.org> (raw)
In-Reply-To: <87k0u0dyqa.fsf@gmx.de> (message from Michael Albinus on Wed, 02 Dec 2020 16:17:01 +0100)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: sbaugh@catern.com,  44638@debbugs.gnu.org
> Date: Wed, 02 Dec 2020 16:17:01 +0100
> 
> Eli, could you run autorevert-test on MS Windows, for the w32notify
> backend? Either a complete run, or just
> 
> $ make -C test autorevert-tests SELECTOR=auto-revert-test07-auto-revert-several-buffers

auto-revert-test07-auto-revert-several-buffers succeeds.  Running the
entire test finds 2 failures:

  2 unexpected results:
     FAILED  auto-revert-test04-auto-revert-mode-dired
     FAILED  auto-revert-test05-global-notify

The evidence for the first failure is:

  Test auto-revert-test04-auto-revert-mode-dired condition:
      (ert-test-failed
       ((should-not
	 (string-match name
		       (substring-no-properties ...)))
	:form
	(string-match "auto-revert-testhf8BmX" "  c:/Documents and Settings/Zaretskii/Local Settings/Temp:\12  total used in directory 1178 available 46.5 GiB\12  drwxrwxrwx  1 Zaretskii None      0 2012-04-16  ..\12  drwxrwxrwx  1 Zaretskii None      0 12-02 17:35 .\12  drwxrwxrwx  1 Zaretskii None      0 09-25 21:47 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\12  drwxrwxrwx  1 Zaretskii None      0 12-01 17:26 acrord32_sbx\12  -rw-rw-rw-  1 Zaretskii None  38296 12...(the rest elided)

Not sure what that means.

The second test fails because:

  Test auto-revert-test05-global-notify condition:
      (ert-test-failed
       ((should
	 (buffer-local-value 'auto-revert-notify-watch-descriptor buf-1))
	:form
	(buffer-local-value auto-revert-notify-watch-descriptor #<killed buffer>)
	:value nil))

Let me know if I can help you more.





  reply	other threads:[~2020-12-02 15:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 16:54 bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Spencer Baugh
2020-11-14 16:54 ` bug#44639: [PATCH 2/2] autorevert: map each watch descriptor to a single buffer Spencer Baugh
2020-12-02 14:50   ` Michael Albinus
2021-01-27  3:59     ` Lars Ingebrigtsen
2021-01-27 16:34       ` Spencer Baugh
2021-01-28  3:29         ` Lars Ingebrigtsen
2021-01-28 14:19           ` Michael Albinus
2020-11-14 17:22 ` bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors Eli Zaretskii
2020-11-14 21:19   ` Spencer Baugh
2020-11-30 18:01     ` Spencer Baugh
2020-11-30 18:21       ` Eli Zaretskii
2020-11-30 18:31         ` Michael Albinus
2020-12-01 20:16           ` Michael Albinus
2020-12-02  3:20             ` Eli Zaretskii
2020-12-02 15:17               ` Michael Albinus
2020-12-02 15:41                 ` Eli Zaretskii [this message]
2020-12-02 17:05                   ` Michael Albinus
2020-12-02 17:13                     ` Eli Zaretskii
2020-12-02 17:20                       ` Michael Albinus
2020-12-02 17:43                         ` Eli Zaretskii
2020-12-03 15:01                         ` Michael Albinus
2020-12-02 17:46                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83360ogqqf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44638@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).