unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Radon Rosborough <radon.neon@gmail.com>
Cc: 48170@debbugs.gnu.org
Subject: bug#48170: next-line on large lines or images skips unexpectedly to next logical line
Date: Mon, 03 May 2021 20:02:00 +0300	[thread overview]
Message-ID: <8335v37nuf.fsf@gnu.org> (raw)
In-Reply-To: <CADB4rJHBorYf77vhNcKOtox3QvxU1MVgAptObwUhdMwfiM4SCQ@mail.gmail.com> (message from Radon Rosborough on Sun, 2 May 2021 13:41:54 -0700)

> From: Radon Rosborough <radon.neon@gmail.com>
> Date: Sun, 2 May 2021 13:41:54 -0700
> 
> The bug is that (under certain circumstances) when using `next-line'
> on a long, visually-wrapped line, instead of moving to the next visual
> line, point moves to the next logical line.
> 
> The "certain circumstances" are as follows:
> 1. Point is within a long logical line that is visually wrapped onto
> at least two visual lines (the visual line containing point, and at
> least one subsequent visual line).
> 2. The window line containing point is the bottom-most window line
> that is fully visible.
> 3. The next window line is partially visible, and the pixel height of
> the visible part of that line is less than the default line height (as
> returned by `default-line-height').

Thanks.  Preliminary analysis indicates that this use case was never
supported, since line-move-visual was introduced in Emacs 23.

This is somewhat tricky to debug (and %$#@! Edebug doesn't help), so
stay tuned.

> I did some debugging in the course of identifying the conditions to
> reproduce the bug, and the problematic behavior seems to come down to
> something in the implementation of `line-move-partial'. There's a
> conditional check (<= this-ypos (- dlh)) in `line-move-partial' that
> gets triggered for certain combinations of window sizes and font
> heights, and the code gated behind this check appears to be buggy,
> resulting in the observed behavior.

In my testing this part is never executed.  And it shouldn't be,
because it handles the case where the window is vscrolled and the
current line starts above the top of the window.  Which is not the
case here, at least not with the default frame size and window that is
not too small.





  reply	other threads:[~2021-05-03 17:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02 20:41 bug#48170: next-line on large lines or images skips unexpectedly to next logical line Radon Rosborough
2021-05-03 17:02 ` Eli Zaretskii [this message]
2021-05-03 17:17   ` Eli Zaretskii
2021-05-09 17:40     ` Radon Rosborough
2021-05-13 13:14       ` Eli Zaretskii
2021-05-15 23:34         ` Radon Rosborough
2021-05-16  4:15           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335v37nuf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48170@debbugs.gnu.org \
    --cc=radon.neon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).