From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems Date: Wed, 09 Jun 2021 14:56:14 +0300 Message-ID: <8335trdzfl.fsf@gnu.org> References: <51cb-60bf4900-1dd-2840bc80@23790836> <875yyoo9gy.fsf@gnus.org> <87r1hcmu2q.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48902@debbugs.gnu.org, mattiase@acm.org, larsi@gnus.org, salutis@me.com, naofumi@yasufuku.dev To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 13:57:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqwph-00076Z-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 13:57:17 +0200 Original-Received: from localhost ([::1]:58866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwpf-0004ZD-3j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 07:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwpS-0004XJ-2h for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqwpR-0003Yl-RT for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqwpR-0000JO-RJ for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 07:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48902 X-GNU-PR-Package: emacs Original-Received: via spool by 48902-submit@debbugs.gnu.org id=B48902.16232398021168 (code B ref 48902); Wed, 09 Jun 2021 11:57:01 +0000 Original-Received: (at 48902) by debbugs.gnu.org; 9 Jun 2021 11:56:42 +0000 Original-Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqwp5-0000Ih-1v for submit@debbugs.gnu.org; Wed, 09 Jun 2021 07:56:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqwp2-0000IQ-4Q for 48902@debbugs.gnu.org; Wed, 09 Jun 2021 07:56:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40160) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwov-00038L-8j; Wed, 09 Jun 2021 07:56:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1739 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwou-00053f-G3; Wed, 09 Jun 2021 07:56:28 -0400 In-Reply-To: (message from Alan Third on Tue, 8 Jun 2021 21:33:01 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208288 Archived-At: > Date: Tue, 8 Jun 2021 21:33:01 +0100 > From: Alan Third > Cc: 48902@debbugs.gnu.org, Lars Ingebrigtsen , > Rudolf Adamkovič , naofumi@yasufuku.dev > > It's not just allocInitFromFile, I'm looking at the other callers of > image_find_image_file and they all call ENCODE_FILE after it too. Encoding an already encoded file name is a no-op. But I agree it's unclean and we had better fixed that. > Patch attached. I've tested it here but I only have a couple of images > to try it with. Thanks, it LGTM. But please also adjust the comment of image_find_image_fd.