From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48740: 28.0.50; Composition text property is not always honoured Date: Thu, 24 Jun 2021 19:06:41 +0300 Message-ID: <8335t7tffy.fsf@gnu.org> References: <87im30ad2g.fsf@localhost> <837djg4gvq.fsf@gnu.org> <87wnrgtlln.fsf@localhost> <8335u449de.fsf@gnu.org> <87pmx8tfub.fsf@localhost> <83y2bw2oyr.fsf@gnu.org> <87eedn12j6.fsf@localhost> <835yyz2ctp.fsf@gnu.org> <878s3tbqvx.fsf@localhost> <83wnrdzjxe.fsf@gnu.org> <87v968ok1k.fsf@localhost> <835yy8vjje.fsf@gnu.org> <87o8c0r801.fsf@localhost> <83r1gvtnr4.fsf@gnu.org> <874kdnwcse.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3016"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48740@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 24 18:07:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwRsj-0000c8-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Jun 2021 18:07:09 +0200 Original-Received: from localhost ([::1]:55806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwRsi-0003YB-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Jun 2021 12:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwRsc-0003Xp-NG for bug-gnu-emacs@gnu.org; Thu, 24 Jun 2021 12:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwRsc-0002DU-GU for bug-gnu-emacs@gnu.org; Thu, 24 Jun 2021 12:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwRsc-0008FR-Bz for bug-gnu-emacs@gnu.org; Thu, 24 Jun 2021 12:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jun 2021 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48740 X-GNU-PR-Package: emacs Original-Received: via spool by 48740-submit@debbugs.gnu.org id=B48740.162455082131697 (code B ref 48740); Thu, 24 Jun 2021 16:07:02 +0000 Original-Received: (at 48740) by debbugs.gnu.org; 24 Jun 2021 16:07:01 +0000 Original-Received: from localhost ([127.0.0.1]:43891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwRsb-0008FA-2F for submit@debbugs.gnu.org; Thu, 24 Jun 2021 12:07:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwRsY-0008Ev-Px for 48740@debbugs.gnu.org; Thu, 24 Jun 2021 12:06:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48486) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwRsT-00027R-J1; Thu, 24 Jun 2021 12:06:53 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3449 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwRsT-0007b8-6K; Thu, 24 Jun 2021 12:06:53 -0400 In-Reply-To: <874kdnwcse.fsf@localhost> (message from Ihor Radchenko on Thu, 24 Jun 2021 22:35:45 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208938 Archived-At: > From: Ihor Radchenko > CC: 48740@debbugs.gnu.org > Date: Thu, 24 Jun 2021 22:35:45 +0800 > > > [1:text/plain Hide] > > Eli Zaretskii writes: > > > What I don't understand is why the property is broken into two > > intervals. You have only one word, ONGOING, so why is the property > > divided into 2? > > As I understand, the composition in the two intervals remains the same. > However, some other text properties differ, so the composition property > is "spread" across the two intervals. OK, so we understand that. But when Emacs splits the interval because other properties differ, it takes care of copying the same property value to both intervals, so the values are 'eq'. > >> 2. The following code in org-agenda-highlight-todo unexpectedly breaks > >> the composition into two intervals with composition values becoming > >> not eq: > > > > Why is this code needed? And why not put the property on the word > > after concatenating, to avoid the issue? > > The code formats todo keyword in agenda line according to > org-agenda-todo-keyword-format. The function does not know if the passed > string has composition property or not. But the caller does. > In any case, changing concat to format fixed the observed problem. Yes, because 'format' attempts to preserve text properties. > I understand. However, the problem is quite unexpected. I do not see how > application can anticipate it. Probably, adding a note to docstring > would be useful? Something like in the attached patch. Fine with me, thanks.