From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Tue, 14 Sep 2021 22:24:22 +0300 Message-ID: <8335q7c655.fsf@gnu.org> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5720"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, 49723@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 21:25:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQE3K-0001GM-Bl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 21:25:10 +0200 Original-Received: from localhost ([::1]:46596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQE3I-0008AQ-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 15:25:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQE3C-0008AF-Sg for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQE3B-0005my-P3 for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQE3B-0000E1-IA for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.1631647477831 (code B ref 49723); Tue, 14 Sep 2021 19:25:01 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 14 Sep 2021 19:24:37 +0000 Original-Received: from localhost ([127.0.0.1]:50205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQE2n-0000DL-5D for submit@debbugs.gnu.org; Tue, 14 Sep 2021 15:24:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQE2l-0000D9-BZ for 49723@debbugs.gnu.org; Tue, 14 Sep 2021 15:24:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQE2f-0005S2-Gc; Tue, 14 Sep 2021 15:24:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2057 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQE2f-0007oi-0b; Tue, 14 Sep 2021 15:24:29 -0400 In-Reply-To: <87pmtbj81v.fsf@gmail.com> (message from Federico Tedin on Tue, 14 Sep 2021 21:01:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214334 Archived-At: > From: Federico Tedin > Cc: 49723@debbugs.gnu.org, Philipp Stephani > Date: Tue, 14 Sep 2021 21:01:16 +0200 > > I'm interested in looking into this one since I want to learn more about > the C side of the codebase. However, I wasn't able to find a call to > expand-file-name in encode_file_name or encode_file_name_1. I did find > the null byte check though (CHECK_TYPE + memchr). Maybe I am missing > something out. My description was inaccurate: the expand-file-name call usually precedes the call to ENCODE_FILE, it is not part of encode_file_name. > I assume that a similar check on expand-file-name should be applied to > both input arguments, NAME and DEFAULT-DIRECTORY? I don't think we need that because expand-file-name calls itself on DEFAULT-DIRECTORY internally. But we may need to perform the check on default-directory, if we use it inside expand-file-name.