From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51658: [PATCH] Haiku port (again) Date: Sat, 20 Nov 2021 11:56:31 +0200 Message-ID: <8335nrtak0.fsf@gnu.org> References: <87ee7surtv.fsf.ref@yahoo.com> <87ee7surtv.fsf@yahoo.com> <83mtmd43fa.fsf@gnu.org> <87ilx0yj52.fsf@yahoo.com> <83czn8424l.fsf@gnu.org> <87o86s41at.fsf@yahoo.com> <83tugk2iuy.fsf@gnu.org> <871r3n4jvd.fsf@yahoo.com> <835ysz2niq.fsf@gnu.org> <87sfw3w372.fsf@yahoo.com> <83zgq7x5zj.fsf@gnu.org> <87r1bjlf26.fsf@yahoo.com> <83wnlbuq7p.fsf@gnu.org> <877ddb6pvi.fsf@yahoo.com> <83ilwvuj3t.fsf@gnu.org> <875ysv58dz.fsf@yahoo.com> <87lf1q2kez.fsf@yahoo.com> <87lf1jqpg0.fsf@yahoo.com> <83fsrrtef6.fsf@gnu.org> <87r1bbp3uz.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40875"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51658@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 10:57:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moN7o-000AUh-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 10:57:37 +0100 Original-Received: from localhost ([::1]:42680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moN7n-00031U-0S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 04:57:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moN7H-0002J9-H5 for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 04:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moN7G-0002sw-8b for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 04:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moN7G-0003E0-4C for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 04:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51658-submit@debbugs.gnu.org id=B51658.163740220912373 (code B ref 51658); Sat, 20 Nov 2021 09:57:02 +0000 Original-Received: (at 51658) by debbugs.gnu.org; 20 Nov 2021 09:56:49 +0000 Original-Received: from localhost ([127.0.0.1]:41753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moN72-0003DV-QX for submit@debbugs.gnu.org; Sat, 20 Nov 2021 04:56:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moN6q-0003D0-Cw for 51658@debbugs.gnu.org; Sat, 20 Nov 2021 04:56:46 -0500 Original-Received: from [2001:470:142:3::e] (port=39676 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moN6l-0002m6-3x; Sat, 20 Nov 2021 04:56:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=K5j9jLqGRGcWLQrQ1WYzVMwTgnp+4vSvtZhE2ecI/g4=; b=PHX+gSRCmb/1 4j3BKRlA3ZlPbrtSawINJ6FDobxl+lFihWaiTHsgiE+nRTJ4JiGGDlZ54yuCuQMSJZZJCTeCUmtT1 wlUZUbjbVttgqDe2LpSLsYBVsYhPuynSrl/jjR2b9aF+dM431GbhAgNw063h3p1UtmMcaC4EhnxHJ 4MJ4XHXSW/OKJF4uLAPj0GxlfQ109E+mhACM0K355p0mJzr2UAr83k839DFuy/5oG9X2vmdOT6//y JLXto1jM7vgG6RmgpzJgxww73nr5kkCnYUBDKwAiqEEDF3PE/fb9pFpxCW2tlQPn/FwAvomdd2saa Q2tSdg5Deqn69iOPAQPj1Q==; Original-Received: from [87.69.77.57] (port=4236 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moN6j-0003r9-Tw; Sat, 20 Nov 2021 04:56:30 -0500 In-Reply-To: <87r1bbp3uz.fsf@yahoo.com> (message from Po Lu on Sat, 20 Nov 2021 17:34:44 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220485 Archived-At: > From: Po Lu > Cc: 51658@debbugs.gnu.org > Date: Sat, 20 Nov 2021 17:34:44 +0800 > > >> (defun tooltip-show-help (msg) > >> "Function installed as `show-help-function'. > >> MSG is either a help string to display, or nil to cancel the display." > >> - (if (display-graphic-p) > >> + (if (and (display-graphic-p) > >> + (or (not (eq window-system 'haiku)) ;; On Haiku, there isn't a reliable way to show tooltips > >> + ;; above menus. > >> + (not (menu-or-popup-active-p)))) > > > This seems to contradict what you wrote in the user manual about > > tooltip options? > > This only disables tooltips on Haiku if a menu or popup is active, as > Haiku doesn't let you map windows or tooltips above them. But the manual doesn't mention that limitation, does it? Does this limitation also affect tooltips produced by Emacs as special frames? > Here's a patch with the other issues you mentioned fixed. Please see if > it's better, thanks. If you fixed everything and feel confident you did, just install it. If there are some places where you want my opinion, please show only those few places. Thanks.