From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected Date: Sun, 09 Jan 2022 12:44:15 +0200 Message-ID: <8335lx2npc.fsf@gnu.org> References: <87k0f9is28.wl-shingo.fg8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21476"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53133@debbugs.gnu.org To: Shingo Tanaka , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 09 11:46:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6Vi6-0005KD-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jan 2022 11:46:02 +0100 Original-Received: from localhost ([::1]:56616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6Vi4-00027Q-OV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jan 2022 05:46:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6Vh8-00026f-48 for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 05:45:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6Vh7-0000K5-Qs for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 05:45:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6Vh7-0003Bv-JG for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 05:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jan 2022 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53133 X-GNU-PR-Package: emacs Original-Received: via spool by 53133-submit@debbugs.gnu.org id=B53133.164172507612213 (code B ref 53133); Sun, 09 Jan 2022 10:45:01 +0000 Original-Received: (at 53133) by debbugs.gnu.org; 9 Jan 2022 10:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:49273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6Vgh-0003Au-MV for submit@debbugs.gnu.org; Sun, 09 Jan 2022 05:44:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6Vgf-0003Ae-B5; Sun, 09 Jan 2022 05:44:34 -0500 Original-Received: from [2001:470:142:3::e] (port=52484 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6VgZ-0000Hk-Vl; Sun, 09 Jan 2022 05:44:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S/bpuWmrf0ZiefFXpbJRPaeoCFLZFX2AgqSRCimZKfw=; b=IWCheP/RiaSJ rb2NpFxuAIoKislIdwbPrTtPU2hZtw7HW+ZhpHPOytO1pCsKyKuy/3/CzPLz0LUCE/bGQaoxa2Wl6 j4wSD4aXPBSVxH45vOc4Xm331xQJwDuuXRF5bJ7jsB94pKVgZeuJ+zBMwE15+QlYV8npaAu5MoIQ0 Olcg8dke5BgW8F6Y7rzPuk9s5/FU/GolusEXTRVJtnX3WQ9ig3s2EMnlYAOqslCPHJ0gueVmSN1F9 ZTPUl3TN9OCQ+/l/YviL2acBo2DQcVKYZGGFJuVP3HNaXKwx80ZG4LdF5GHWHal8ZyZX+S6W44opF VYV9nfW0nROHtXwlTWIm1w==; Original-Received: from [87.69.77.57] (port=4141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6VgZ-0008DD-Vz; Sun, 09 Jan 2022 05:44:28 -0500 In-Reply-To: <87k0f9is28.wl-shingo.fg8@gmail.com> (message from Shingo Tanaka on Sun, 09 Jan 2022 11:03:27 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223840 Archived-At: unarchive 48639 reopen 48639 thanks > Date: Sun, 09 Jan 2022 11:03:27 +0900 > From: Shingo Tanaka > > Here is how to reproduce: > 1. Open Emacs from terminal with `emacs --no-init-file' > 2. Type M-x list-buffers > 3. Type C-x o (go to Buffer Menu) > 4. Type C-M-Right 5 times to move on to "Fundamental" in "Mode" column > 5. Type S 2 times or more to toggle sorting order > 6. You will be able to see that "Size" column is selected as the sorting column > unexpectedly > > Looks like below change from 28.0.50 is releated to this issue, because it > disappears when I just rewind this change. > > --- tabulated-list.el.org 2022-01-06 22:32:13.936852142 +0900 > +++ tabulated-list.el 2022-01-07 15:15:42.000000000 +0900 > @@ -574,7 +581,8 @@ > (when not-last-col > (when (> pad-right 0) (insert (make-string pad-right ?\s))) > (insert (propertize > - (make-string (- width (min width label-width)) ?\s) > + ;; We need at least one space to align correctly. > + (make-string (- width (min 1 width label-width)) ?\s) > 'display `(space :align-to ,next-x)))) > (put-text-property opoint (point) 'tabulated-list-column-name name) > next-x))) You are right. Stefan, I reverted that change and I'm reopening bug#48639. This problem is a much more serious regression than what happens sometimes when text-size is scaled. We will need to find another fix for that bug, most probably in one of the hooks used by tabulated-list.el, by adding the display property only when actually needed.