From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53636: 29.0.50; face-remapping broken on master Date: Sun, 06 Feb 2022 09:12:45 +0200 Message-ID: <8335kw1n9u.fsf@gnu.org> References: <87o83tib13.fsf@gnu.org> <871r0p9l4f.fsf@gnus.org> <83ee4p9izg.fsf@gnu.org> <87mtjd8485.fsf@gnus.org> <83a6fd9glm.fsf@gnu.org> <835yq19dk1.fsf@gnu.org> <87czk97yt6.fsf@gnus.org> <8335l49jwu.fsf@gnu.org> <835ypz8zbm.fsf@gnu.org> <87fsp2v0ky.fsf@gnus.org> <83leyu73i8.fsf@gnu.org> <87k0edrvxm.fsf@gnus.org> <83sft15egx.fsf@gnu.org> <871r0loxr9.fsf@gnus.org> <83mtj85tm1.fsf@gnu.org> <87wnibn48c.fsf@gnus.org> <8335kz4tgu.fsf@gnu.org> <87ee4hg7g6.fsf@gnus.org> <83y22p21na.fsf@gnu.org> <871r0haqzr.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53636@debbugs.gnu.org, tsdh@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 08:14:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGbke-0003Aj-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 08:14:24 +0100 Original-Received: from localhost ([::1]:55746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGbkd-0008I2-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 02:14:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGbkI-0008H2-Ji for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 02:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGbkI-0002Hu-8R for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 02:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGbkH-0005Sv-VB for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 02:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 07:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53636-submit@debbugs.gnu.org id=B53636.164413159020939 (code B ref 53636); Sun, 06 Feb 2022 07:14:01 +0000 Original-Received: (at 53636) by debbugs.gnu.org; 6 Feb 2022 07:13:10 +0000 Original-Received: from localhost ([127.0.0.1]:36246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGbjR-0005Rf-Rv for submit@debbugs.gnu.org; Sun, 06 Feb 2022 02:13:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGbjQ-0005RQ-4u for 53636@debbugs.gnu.org; Sun, 06 Feb 2022 02:13:08 -0500 Original-Received: from [2001:470:142:3::e] (port=52190 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGbjK-0002EQ-Or; Sun, 06 Feb 2022 02:13:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NKXFJ725VO5wj0V3AfLHoc7lqUsOROK6bnSXSYlAQV4=; b=gvT618GYO9v8 oIYgpt0OLNGPcgAaaWwk0/mmTmypW2PO8MDFTD48YVIRJYdFxW8gFD0SKktVuyuGnsD94qXOGWH1K PZeck+hmMwQRHdvEY/hId7Nwt3g2bLXIJoN//je/FlTtF1eGQF0P92EaxXu/P+Jy6lP4Hzh+QGnDc +ZvE6ghqwpo2WQDiCE8vzGxxe1a2uftmUov9wLCBdcDnIkfJ4Bgof3eE2jPQTAtWvpOP/VHbyKwNk y/DXFmMLOnqJzQh9nBO78AlJbtsxn8KcFMeG6gtTzndJMn6/9l+W8O6Lw8L2yyq8ErJ3Mm4NKL/4d 8fqHCXaJhlVh8k5B8IFd7g==; Original-Received: from [87.69.77.57] (port=3387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGbjJ-0003Sw-To; Sun, 06 Feb 2022 02:13:02 -0500 In-Reply-To: <871r0haqzr.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 05 Feb 2022 23:27:36 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226135 Archived-At: > From: Lars Ingebrigtsen > Cc: 53636@debbugs.gnu.org, tsdh@gnu.org > Date: Sat, 05 Feb 2022 23:27:36 +0100 > > (progn > (face-remap-add-relative 'mode-line 'link-visited) > (make-frame)) > > vs > > (progn > (face-remap-add-relative 'mode-line 'link-visited) > (switch-to-buffer "*Messages*") > (make-frame)) > > In the first case, the new frame will have mode-line remapped to > link-visited in all windows, while in the latter it won't. So it looks > like a pretty simple bug -- `make-frame' (when computing the faces for > the new frame) is using the buffer-local value of > `face-remapping-alist' instead of the global one. But which case is considered a bug? In the first case, the mode line of *scratch* is affected in the second frame; in the second case the remapping doesn't show in that buffer on _any_ frame, although face-remapping-alist is updated. > But after poking at the code for a couple minutes, I'm not sure where > the computation for faces is done for new faces. Hm... is it > `face-spec-recalc'? Hm... but that doesn't access > `face-remapping-alist'... Is this done at a lower level? What is "this" and "the computation" which you are asking about here?