From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Date: Sun, 01 May 2022 15:49:30 +0300 Message-ID: <8335ht76zp.fsf@gnu.org> References: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> <87wnf5mpt4.fsf@gnus.org> <4c66528e-5d99-719f-6d40-dcf604849200@daniel-mendler.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 55205@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 01 14:50:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl92O-0004LR-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 14:50:57 +0200 Original-Received: from localhost ([::1]:39028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nl92N-00042f-6n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 08:50:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nl91W-00042W-Og for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 08:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nl91W-0001g0-AQ for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 08:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nl91W-0007Ed-7M for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2022 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55205 X-GNU-PR-Package: emacs Original-Received: via spool by 55205-submit@debbugs.gnu.org id=B55205.165140937227766 (code B ref 55205); Sun, 01 May 2022 12:50:02 +0000 Original-Received: (at 55205) by debbugs.gnu.org; 1 May 2022 12:49:32 +0000 Original-Received: from localhost ([127.0.0.1]:59842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nl912-0007Dl-2l for submit@debbugs.gnu.org; Sun, 01 May 2022 08:49:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nl911-0007Da-49 for 55205@debbugs.gnu.org; Sun, 01 May 2022 08:49:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nl90u-0001Pw-Kd; Sun, 01 May 2022 08:49:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=r+Qn7xW7I4G38LsEhnVmFjaG89gCLF52NaR4bCYQoy0=; b=c96OsaGD46Cl 81CsBFvsnrxEtW3gHwqK4M9OPqEqLgKcEoZLOyNNf5jS6NL2S2JtbRhIwW6rj5oYbuWfj3fayxTSM DSFR7U9by72qWlmBcajPVoeG4KHQBdVbLMFPnLcqmZAtsDNLphWHcI3TMcfbtsqrGIQ1oBUtTDXQq MOVMmiQuzJg88ZbSiKszVirp3t6CgCIITxkM3aAm9ZnH1E1slyFgHbFd1u2qTK6q+Y65JG25NXNYZ I9gy/jWmgZdJlz8vbKVyySMVkNG0sx7OqCs/QwxePtVhNzNB7yvlfyE3xNGua0lHZV3i3YLqD1Wz8 w5C75TCuF/YHONIXj6gW4w==; Original-Received: from [87.69.77.57] (port=4760 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nl90u-0005ah-4e; Sun, 01 May 2022 08:49:24 -0400 In-Reply-To: <4c66528e-5d99-719f-6d40-dcf604849200@daniel-mendler.de> (message from Daniel Mendler on Sun, 1 May 2022 14:40:54 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231136 Archived-At: > Date: Sun, 1 May 2022 14:40:54 +0200 > From: Daniel Mendler > Cc: Stefan Monnier , 55205@debbugs.gnu.org > > No, documenting this is not sufficient. I agree that mutating is not > strictly speaking illegal as a side effect of completion--replace, but > unfortunate and bad API design. > > But the bug report here is about an actual bug in > minibuffer-force-complete which relies on completion--replace. As a > consequence completion candidate strings are *illegally mutated*. I > propose to fix such issues once and for all by removing the unfortunate > mutation in completion--replace. As an aside, please don't use "illegal" unless you mean something that is against the law. GNU Coding Standards frown on using "illegal" for something that is merely incorrect or invalid coding practices.