From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54296: Add buffer-matching functionality Date: Mon, 13 Jun 2022 15:13:18 +0300 Message-ID: <8335g8vk0x.fsf@gnu.org> References: <87ee3d4cli.fsf@posteo.net> <87k0d35c82.fsf@gnus.org> <877d92unqn.fsf@posteo.net> <83bkyednvx.fsf@gnu.org> <87cziudmyg.fsf@posteo.net> <838rtheogd.fsf@gnu.org> <87ilskbgul.fsf@posteo.net> <83ilskcp9i.fsf@gnu.org> <87v8whio1a.fsf@posteo.net> <83czipkylw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27935"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54296@debbugs.gnu.org, philipk@posteo.net, larsi@gnus.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 13 14:20:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0j32-00072J-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 14:20:00 +0200 Original-Received: from localhost ([::1]:42270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0j31-0007OP-36 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 08:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0ixK-0001lw-DQ for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 08:14:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0ixH-0007wm-7c for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 08:14:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0ixH-00048a-3k for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 08:14:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 12:14:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54296-submit@debbugs.gnu.org id=B54296.165512242015849 (code B ref 54296); Mon, 13 Jun 2022 12:14:03 +0000 Original-Received: (at 54296) by debbugs.gnu.org; 13 Jun 2022 12:13:40 +0000 Original-Received: from localhost ([127.0.0.1]:57436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0iwu-00047Z-Gh for submit@debbugs.gnu.org; Mon, 13 Jun 2022 08:13:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0iwt-00047N-0S for 54296@debbugs.gnu.org; Mon, 13 Jun 2022 08:13:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0iwn-0007ui-Fo; Mon, 13 Jun 2022 08:13:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q7DbHqtGVrGPh319qTupFDnkcJqcX6W67+7gHTaELm8=; b=GIzDKVWun39M BfMmasXw3FkGnEKQOMqjMDTaVq0VIe5uzNxXRie7Z8JFASvWc2rWDuhaOgs+0YKeJtA70qd5aQ8aG KQ5LNQGVBZm9H6eWDRnPdTp4gFxDiBAapjTnH0fD1FGZuH6HDi3aRfgZ3sOSAiljM7QB1Bc1lm2e9 BytYchu8XEy9HBCadmr4jhWVp2mFy6OPx3uA7r2zbGzBtUyTvWCcGBBz91yBwuHGgpQKZ/wedurK7 bfFjzxHKkSbFB1ZnR+wKn8o+YLufUFGvPuujKb2h7aj2iWR2nPIXQWnSGuRKIyetBC5VMIyeN9cw2 mB5qdVmdnEL1bXTuI4BdTQ==; Original-Received: from [87.69.77.57] (port=1956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0iwm-0001OW-G1; Mon, 13 Jun 2022 08:13:33 -0400 In-Reply-To: (message from Dmitry Gutov on Mon, 13 Jun 2022 03:23:47 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234387 Archived-At: > Date: Mon, 13 Jun 2022 03:23:47 +0300 > Cc: 54296@debbugs.gnu.org, larsi@gnus.org > From: Dmitry Gutov > > On 14.03.2022 05:21, Eli Zaretskii wrote: > > I still don't think I understand why it is so > > important that we should provide a special case for it. > > It's pretty valuable to be able to provide a default value of > project-kill-buffer-conditions which can be read at a glance (including > in compiled Emacs) and easily edited via customize-variable by a user > with little to no knowledge of Elisp. > > And 'major-mode' was used twice inside project-kill-buffer-conditions, > not just once. I think I lost context, so please bear with me. My "still don't think I understand" comment was about the need to support major-mode when apparently the _only_ user of that is fundamental-mode, where we cannot use derived-mode instead. If indeed fundamental-mode is the only case where major-mode is useful, I asked why not use a predicate that tests explicitly for that case. And if I understand your reasoning above, then doesn't (eq major-mode 'fundamental-mode) provide an easy default that can be read at a glance? Or what am I missing?