From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 56553@debbugs.gnu.org
Subject: bug#56553: 29.0.50; ASAN error with fringe bitmaps on NS
Date: Thu, 14 Jul 2022 19:55:41 +0300 [thread overview]
Message-ID: <8335f3tz02.fsf@gnu.org> (raw)
In-Reply-To: <8569ECF9-6D19-4DCB-854C-2755D182F8AF@gmail.com> (message from Gerd Möllmann on Thu, 14 Jul 2022 16:34:05 +0200)
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Date: Thu, 14 Jul 2022 16:34:05 +0200
> Cc: 56553@debbugs.gnu.org
>
>
> On 2022-07-14,, at 16:18 , Gerd Möllmann <gerd.moellmann@gmail.com> wrote:
>
> frame #5: 0x000000010116d2b4 emacs`ns_define_fringe_bitmap(which=27,
> bits=0x00000001066e1860, h=12, w=16) at nsterm.m:2906:20
> 2903 /* XBM rows are always round numbers of bytes, with any unused
> 2904 bits ignored. */
> 2905 int byte = y * (w/8 + (w%8 ? 1 : 0)) + x/8;
> -> 2906 bool bit = bits[byte] & (0x80 >> x%8);
>
> I think the problem is indeed that bits is unsigned short*. Otherwise, the /8 and %8 in line 2903 don't make
> sense to me. I think "byte" computes an index in a byte (char) array.
>
> WDYT?
Do you understand what that loop is trying to do? What is this line
about:
if (bit)
[p appendBezierPathWithRect:NSMakeRect (x, y, 1, 1)];
Anyway, it sounds like you are saying that the code wants to access
the individual bytes of the 'short' elements?
next prev parent reply other threads:[~2022-07-14 16:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 13:03 bug#56553: 29.0.50; ASAN error with fringe bitmaps on NS Gerd Möllmann
2022-07-14 13:56 ` Eli Zaretskii
2022-07-14 14:18 ` Gerd Möllmann
2022-07-14 14:34 ` Gerd Möllmann
2022-07-14 16:55 ` Eli Zaretskii [this message]
2022-07-14 18:25 ` Gerd Möllmann
2022-07-15 8:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-15 9:14 ` Gerd Möllmann
2022-07-15 10:37 ` Eli Zaretskii
2022-07-15 13:55 ` Gerd Möllmann
2022-07-15 13:57 ` Robert Pluim
2022-07-15 14:26 ` Eli Zaretskii
2022-07-15 14:46 ` Andreas Schwab
2022-07-15 15:10 ` Gerd Möllmann
2022-07-15 15:16 ` Gerd Möllmann
2022-07-16 7:16 ` Gerd Möllmann
2022-07-15 15:32 ` Andreas Schwab
2022-07-15 10:35 ` Eli Zaretskii
2022-07-15 10:37 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335f3tz02.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56553@debbugs.gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).