From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58168: string-lessp glitches and inconsistencies Date: Fri, 14 Oct 2022 18:31:14 +0300 Message-ID: <8335bq8lrx.fsf@gnu.org> References: <7824372D-8002-4639-8AEE-E80A6D5FEFC6@gmail.com> <83czbef6le.fsf@gnu.org> <6CB805F6-89EE-4D7C-A398-F29698733A42@gmail.com> <83h70oce4k.fsf@gnu.org> <83tu4mais1.fsf@gnu.org> <83wn9gw2sp.fsf@gnu.org> <83wn9dp5xp.fsf@gnu.org> <83lepqlqdy.fsf@gnu.org> <3C87B8E6-A52B-41B6-A959-954BBB5F788E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9158"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58168@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 14 17:49:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojMvt-0002Ez-Pj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 17:49:10 +0200 Original-Received: from localhost ([::1]:45010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojMvr-0004BL-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 11:49:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMgK-00085B-6D for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 11:33:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojMgI-0002AU-Pt for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 11:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojMgI-00078K-6i for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 11:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58168 X-GNU-PR-Package: emacs Original-Received: via spool by 58168-submit@debbugs.gnu.org id=B58168.166576153027344 (code B ref 58168); Fri, 14 Oct 2022 15:33:02 +0000 Original-Received: (at 58168) by debbugs.gnu.org; 14 Oct 2022 15:32:10 +0000 Original-Received: from localhost ([127.0.0.1]:38360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMfR-00076y-LH for submit@debbugs.gnu.org; Fri, 14 Oct 2022 11:32:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojMfH-00076J-SL for 58168@debbugs.gnu.org; Fri, 14 Oct 2022 11:32:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMf6-00022r-ER; Fri, 14 Oct 2022 11:31:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lSPIq9yXcYeba8XeTYL4Yj15FgR5i5f+Fp9xZ7ePrqU=; b=MrHvY+we7vtx0mkjqL5A JLO7Rzxj8+AVEQEbFcN9MxJX/N+WQQP+A2f30ASmpYZYq3Wlmt9gHdUw5wVEOC6lTEXODzpkO5xGu Q7vBLk79BzpFDitrTfBbW3ytkGnvLDgJ6vc0hUjxFIXT5D7qFCfXGLe5bJQcXNZcSh26dLoOXUA/i /2pkHHkVcxq4/k0LVvNLMCVplXWiuR7U5nRdTtMHPg/hUFVG3VxDUqTT2NKekOE6hDivc5qpsmEMc ZVuIjE+gaSF+g2iZftnz1AAvB19S8XT779lu9UlfdahOFMKndz8rYfuxWNFJmYUwiay4AUZcSHzkZ tZKzcNWVYJMVUA==; Original-Received: from [87.69.77.57] (port=1984 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMek-0002U2-El; Fri, 14 Oct 2022 11:31:28 -0400 In-Reply-To: <3C87B8E6-A52B-41B6-A959-954BBB5F788E@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 14 Oct 2022 16:39:55 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245459 Archived-At: > From: Mattias Engdegård > Date: Fri, 14 Oct 2022 16:39:55 +0200 > Cc: 58168@debbugs.gnu.org > > As performance is more acceptable now I'm not going to take any further action with respect of string<, but let me just answer your questions: > > 8 okt. 2022 kl. 09.35 skrev Eli Zaretskii : > > > I suggested to use memchr to find whether a string has any > > C0 or C1 bytes, _before_ doing the actual comparison, to find out > > whether a multibyte string includes any raw bytes, which would then > > require slower comparisons. > > That isn't practical; we would traverse each argument in full, twice, even if there is a difference early on. While memchr is fast for what it does, it will still need to look at every bit of its input. I fail to see how the number of times we'd traverse the strings is of concern, as long as it's fast enough. And memchr _is_ very fast.