From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58708: 29.0.50; [PATCH] Fix build error that gflags.will_dump_ not surround by the directives as its definition Date: Tue, 25 Oct 2022 14:57:05 +0300 Message-ID: <8335bcp14e.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26871"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58708-done@debbugs.gnu.org To: lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 25 13:59:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onIaL-0006l6-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Oct 2022 13:59:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onIZH-0005pw-Rg; Tue, 25 Oct 2022 07:58:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onIZG-0005pS-QY for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2022 07:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onIZG-0001zM-J6 for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2022 07:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onIZG-0004wD-Ei for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2022 07:58:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2022 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 58708@debbugs.gnu.org, eliz@gnu.org, sunlin7@yahoo.com Original-Received: via spool by 58708-done@debbugs.gnu.org id=D58708.166669904518933 (code D ref 58708); Tue, 25 Oct 2022 11:58:02 +0000 Original-Received: (at 58708-done) by debbugs.gnu.org; 25 Oct 2022 11:57:25 +0000 Original-Received: from localhost ([127.0.0.1]:50588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onIYf-0004vJ-BK for submit@debbugs.gnu.org; Tue, 25 Oct 2022 07:57:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onIYd-0004v6-9I for 58708-done@debbugs.gnu.org; Tue, 25 Oct 2022 07:57:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onIYY-0001pv-2z; Tue, 25 Oct 2022 07:57:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=u82nRiHQAdCepfsfuZZlL5V5zC3J2iWYrTCjyO1KJRU=; b=cxZnQXVMTJi7 xn/FKbVogV1xWy1U5GdvwvEwgs7rZzNEh00bCJ/KF41NDJjfaWcPG6wxLd/x3ari/8Y6lpcdYjTFt uQ6FzGbo45EUSWfifnBhdE91aRI5XPuIe2RAvDsEz3xg/IPsEty0ShNew15AvjuhlKZZQR7XlWLvu +d47p5NvLEfmOn4JIYEIwPuB0CCw0+4pA7lVGlkcisfSF86V3sLrrIPhp48iKlLUuLzlVCprGDAFd 5TTLq40mawx8YY+xqUGWF6S3lg7vu4uEAt3wsusZ4XnK5ZWx0EjMx1F3gxi2S63eRJOh0wSbMPFr0 qzL8aIRWGpG3tehZbRcPqg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onIYX-0006EV-8R; Tue, 25 Oct 2022 07:57:17 -0400 In-Reply-To: (message from lin Sun on Tue, 25 Oct 2022 05:32:09 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246142 Archived-At: > From: lin Sun > Date: Tue, 25 Oct 2022 05:32:09 +0000 > > Agree with you. And I had removed the directives that surround the > gflags.will_dump_ and the gflags.will_bootstrap_, then rebuilt emacs > with / without the dumper, it seems OK. > Please help review the patch. Thanks. Thanks, installed. Btw, you use both in your email and in the patch 2 different email accounts, none of which is recorded with your copyright assignment. This is confusing. Could you please use one of the email addresses that are in your assignment? TIA.