From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sun, 30 Oct 2022 08:41:00 +0200 Message-ID: <8335b5hkzn.fsf@gnu.org> References: <32829.1667088546@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 07:42:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op21U-0006wl-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 07:42:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op21D-0001Nu-D1; Sun, 30 Oct 2022 02:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op21C-0001Nm-Lv for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op21C-0004PX-8s for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op21B-00085l-TY for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 06:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166711208731063 (code B ref 58721); Sun, 30 Oct 2022 06:42:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 30 Oct 2022 06:41:27 +0000 Original-Received: from localhost ([127.0.0.1]:37186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op20c-00084x-Mj for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:41:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op20a-00084i-3p for 58721@debbugs.gnu.org; Sun, 30 Oct 2022 02:41:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op20U-0004JJ-Km; Sun, 30 Oct 2022 02:41:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0LKsNMxeT0Y1Nm5PTTMm4Ia2VA24dEfCrBMadTJdwXU=; b=fJnY8uufOxmY 13YfmvQBg6kDFtvoMhat/NEDx6hr+ERXalYR02zPsGCqolJo+k/5YOt1TvDcqNQ4UNxG+lT63Go9h Zn2+QTnRH77YQbnD9zxlVucZLemM40GSUS2nb15RoUL/2B/h9U7GMZsVooDUr5YDn/PB0w5PNX8MV nSxzyX0yqXgXs8yGOqIEdfBWhYRylvLs5j9WFkZqjh3BzELkyr0Rs+854FtpQbXicIR/AzAIWJ1Ku 8O2Uvr85sIPbYpb7QJj+9KkGFQRHvEgdqPSS0g4E93MNUA2HQCMqMrcK4JaeyVlBnfTCxDocEazAI gWaPzORmeEuWwp4XCpGiNg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op20T-0004ht-Vl; Sun, 30 Oct 2022 02:41:18 -0400 In-Reply-To: <32829.1667088546@alto> (message from Mike Kupfer on Sat, 29 Oct 2022 17:09:06 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246590 Archived-At: > From: Mike Kupfer > cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com > Date: Sat, 29 Oct 2022 17:09:06 -0700 > > Eli Zaretskii wrote: > > > Yet another possibility is to refrain from calling rename-file when > > the moved file is a directory, and instead to do what rename-file > > does, with a twist, "by hand". That is what I actually prefer, as > > nothing is really wrong with rename-file. > > I'm afraid I don't understand your suggestion. > > I've attached the proof-of-concept patch that I came up with, which just > modifies move-file-to-trash. I've tested it with files and directories, > both same-filesystem and crossing filesystems. Did you have in mind > something similar? Yes, thanks. I just thought you'd be able to call copy-directory, similarly (but differently) to what rename-file does, instead of using your lambda-function.