From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Mon, 23 Jan 2023 15:01:56 +0200 Message-ID: <833581jtff.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 23 14:02:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJwSp-0008CT-4L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Jan 2023 14:02:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJwSg-0003Az-38; Mon, 23 Jan 2023 08:02:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJwSa-00032j-Fk for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 08:02:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJwSa-0003pz-6I for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 08:02:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJwSZ-00068s-Un for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 08:02:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2023 13:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.167447892223588 (code B ref 60841); Mon, 23 Jan 2023 13:02:03 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 23 Jan 2023 13:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:53593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJwSX-00068F-9v for submit@debbugs.gnu.org; Mon, 23 Jan 2023 08:02:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJwSR-00067U-ME for 60841@debbugs.gnu.org; Mon, 23 Jan 2023 08:01:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJwSL-0003gR-P3; Mon, 23 Jan 2023 08:01:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YyvjWympu+v8EOEFZLN1CkN22DDj5fadoB5M9ar+FlU=; b=BvFUc2iA/Jiu3yzls71Z MctXWWgRpO1IZYNheW5u/72Akx2DXEY4Zp2hoUbR8q4r7/r0JZOodvcOcBHT1C54gVrcgX8MhsGi+ jTrpq+GN1IoU6kh5fwvCfp9KFFO3t1QStT2bOlKRl7CMXP9o7gIg5FgG+iGyCef9V1wnNEO/YlUhC sXRY+LBBc/VVRPYiRQYbejhjg3XOYCCyOZias/YqRaGPYc2+ylk/OBD0tDSk4WC8dvvA3cp14P/Z3 DBa0otK9tOK02wohE95UUFmtuQGHQA1w3Y/aL+6/w8zIloUHZ5ruvoOg6z5iKutivrx7e1HNSzqPL hPGgq22iXUPDgg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJwSK-000099-Ks; Mon, 23 Jan 2023 08:01:49 -0500 In-Reply-To: <87fsc2qjcs.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Sun, 22 Jan 2023 23:45:23 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253990 Archived-At: > From: Kévin Le Gouguec > Cc: gregory@heytings.org, 60841@debbugs.gnu.org > Date: Sun, 22 Jan 2023 23:45:23 +0100 > > > The default face is always extended, so it should be treated as > > implicitly having the :extend attribute set. > > > > I think face-differs-from-default-p should be fixed to either ignore > > the :extend attribute like it ignores :inherit (since it could be > > argued that :extend doesn't really control how the face affects > > characters on display), or it should treat the default face as having > > the :extend attribute with the value t. > > I have been slowly converging toward "ignore :extend" being TRT. Fine by me. > * that seq-difference call makes me inexplicably nervous; I thought I > vaguely remembered debates on whether preloaded libraries {c,sh}ould > use seq.el functions, but then I see that "emacs-lisp/seq" is already > in preloaded-file-list, and e.g. rmc.el calls some of its functions. > Am I misremembering? seq.el is indeed preloaded, so that ship has sailed. But you still need to make sure seq is loaded _before_ any preloaded file which uses it, and in this case faces is loaded before seq, so you cannot use seq-difference. And, btw, I cannot say I understand why using seq-difference here is justified. Why not just call delq twice and be done? > >> (Hm, and against my better judgement I went ahead and compared > >> gui_supports_face_attributes_p vs tty_supports_face_attributes_p, and I > >> see that they handle :extend differently and *mashes C-c C-c with > >> forehead before fingers can type another wall of text*) > > > > TTY frames always extend the color, that's the reason for the > > difference. > > (Not sure I get your meaning here; on the Linux TTY I have on hand, > (set-face-extend 'region nil) does disable color extension) I'm sorry, you will have to look up the discussion that led to the development of the :extend attribute; I cannot afford searching for it. The differences between TTY and GUI frames were one of the main reasons why we introduced this attribute. Maybe what I remember happens only on some terminals. Or maybe I'm misremembering and it was because of underline and not the color. But there is definitely a difference. > +(defun region-highlighted-p () > + "Say whether the region is visibly highlighted. Please drop the "Say" part, it's not our style. And I'd use some other word instead of "highlighted", because that could be misinterpreted (the region is supposed to be highlighted). Something like "stands-out" perhaps?