unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 61091@debbugs.gnu.org, rms@gnu.org
Subject: bug#61091: 30.0.50; y-or-n-p clobbers match data
Date: Fri, 27 Jan 2023 17:00:24 +0200	[thread overview]
Message-ID: <83357wc99z.fsf@gnu.org> (raw)
In-Reply-To: <87cz70jb55.fsf@web.de> (message from Michael Heerdegen on Fri, 27 Jan 2023 15:38:14 +0100)

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: rms@gnu.org,  61091@debbugs.gnu.org
> Date: Fri, 27 Jan 2023 15:38:14 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > y-or-n-p originally was implemented in C and was relatively simple.
> > Since then it was moved to Lisp and became a monster, see subr.el.  It
> > is anyone's guess where in that code we clobber the match data.
> 
> I see that the code calls `substitute-command-keys' which potentially
> changes match data.

Yes, that's also my prime suspect.





  reply	other threads:[~2023-01-27 15:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  4:05 bug#61091: 30.0.50; y-or-n-p clobbers match data Richard Stallman
2023-01-27  7:52 ` Eli Zaretskii
2023-01-27 14:38   ` Michael Heerdegen
2023-01-27 15:00     ` Eli Zaretskii [this message]
2023-01-29  5:18   ` Richard Stallman
2023-01-29  6:40     ` Eli Zaretskii
2023-02-04  5:15       ` Richard Stallman
2023-02-04  8:16         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83357wc99z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61091@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).