From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Thu, 09 Feb 2023 09:01:41 +0200 Message-ID: <83357fnwyy.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40359"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca To: Gregory Heytings , Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 09 08:02:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ0wp-000AFk-Qb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Feb 2023 08:02:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ0wY-0003d2-FP; Thu, 09 Feb 2023 02:02:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ0wU-0003cQ-Oo for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 02:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ0wU-0005mu-F3 for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 02:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQ0wT-0005jD-Vw for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 02:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Feb 2023 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167592609321980 (code B ref 56682); Thu, 09 Feb 2023 07:02:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 9 Feb 2023 07:01:33 +0000 Original-Received: from localhost ([127.0.0.1]:57260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ0w1-0005iR-7L for submit@debbugs.gnu.org; Thu, 09 Feb 2023 02:01:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ0vw-0005iA-OZ for 56682@debbugs.gnu.org; Thu, 09 Feb 2023 02:01:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ0vp-0005cj-Jh; Thu, 09 Feb 2023 02:01:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qaKAdaHBSRuaZZOVI9WZcw/75C36FR/srgEQv5Wseus=; b=eovVfmpXv1L+ EGqDDqu469EHjsm138H+5V9iLxoF0t6t30WaWFH2mMJzEeKI0pYcyI8NS/Ee69NkO8VZSL0ifLp48 iXkfgr6SK7k5FymKA0CP9xpc43HEb7ksSWcyxj+wJ0nXr8HZ6JK3YO+Jdynjn6HPsrzNM4puvqsqs awjzDDfGGHy4WH7/xFIpLJppyZef91lAJYem5izPG202g0TyfTWLFxfDGXxoZENYJxiPVLj7a2qz5 FdSh9Kn9K5cZGMkNkc+oZE5Z7Pd/yVgHvNcI8Zj4lmGnN7NoaMOsnZigWkoDqemt6Cg+v8CjHOdln tPLKPKYrkWXTmru+cPiE9A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ0vp-0000PA-1a; Thu, 09 Feb 2023 02:01:21 -0500 In-Reply-To: (message from Gregory Heytings on Thu, 09 Feb 2023 01:57:50 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255190 Archived-At: > Date: Thu, 09 Feb 2023 01:57:50 +0000 > From: Gregory Heytings > cc: monnier@iro.umontreal.ca, 56682@debbugs.gnu.org > > > As promised, I worked on this. Alas, while doing that I found out that > the existing code had a grave bug, which I corrected. However, this > touches src/bytecode.c, lisp/emacs-lisp/bytecomp.el and src/comp.c, so I'm > (to say the least) uncomfortable pushing that fix to emacs-29. The result > of the bug fix, a few renames, the documentation update, and an added > test, is in scratch/fix-locked-narrowing. I did a make bootstrap and a > make check after each step, all of them succeeded. Thanks. Please describe the bug you discovered and the changes made to fix it (and maybe also alternatives if you considered them). It is not easy to glean that information from the changes, as they involve also renaming of variables (which, at this late stage, I don't think you should have done without discussion, btw), documentation changes, and perhaps more. Also, did you test this both with and without native-compilation? Andrea, could you please see if the changes on that branch are okay as far as native-compilation is concerned?