From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Sat, 25 Feb 2023 15:47:21 +0200 Message-ID: <83356tluvq.fsf@gnu.org> References: <87a614g628.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <87lekn9ss3.fsf@gmail.com> <83h6vbntqd.fsf@gnu.org> <878rgn9r6u.fsf@gmail.com> <83edqfnq5u.fsf@gnu.org> <83bkljnpck.fsf@gnu.org> <874jrb9l6d.fsf@gmail.com> <834jrbnlaf.fsf@gnu.org> <87v8jr83ic.fsf@gmail.com> <83v8jrm4r0.fsf@gnu.org> <87fsav7x81.fsf@gmail.com> <83a612ko73.fsf@gnu.org> <87ttza3rwh.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20793"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61726@debbugs.gnu.org, joaotavora@gmail.com To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 25 14:48:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVuuO-0005FJ-Cm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Feb 2023 14:48:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVuuB-00065K-TP; Sat, 25 Feb 2023 08:48:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVuuA-00065C-Gd for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 08:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVuuA-0002Dq-0l for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 08:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVuu9-0007kv-Go for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 08:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Feb 2023 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167733284729658 (code B ref 61726); Sat, 25 Feb 2023 13:48:01 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 25 Feb 2023 13:47:27 +0000 Original-Received: from localhost ([127.0.0.1]:39354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVutb-0007iI-75 for submit@debbugs.gnu.org; Sat, 25 Feb 2023 08:47:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVutZ-0007i5-ER for 61726@debbugs.gnu.org; Sat, 25 Feb 2023 08:47:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVutU-00027n-5I; Sat, 25 Feb 2023 08:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XjN5smGdoYxdUHU89lZqBuckquWVjwIRWk7CGuCsk5U=; b=I8szLl5bvnf9 IW6yQ0MwBCjEHFDm9m15qI6vfu6oau5q9i9uR2GWvSaVqRzuWp7ARXQ0Js4fxiNEsIK7fakiPzoiH kurZwof8DkJDVOd1P+MAXHpu/I+CfNhlAwTgz7niVl5cweTaP8BccosU7PXCrUY9NJAAvDqo243j+ ejauoDNDlgvjm5ViNonx8MGn/HRxMa9o2NHMkL3xzh5OTNlT+6JRaNz5ME7KvQdjei0GJ9FDfdBHZ aqRKv27MQdLrc8ZfAWwtoeeGbbPrYtdNWMHJQBA68O4kUa1LZ0Wi00xbnRrEXtxRiXqkJFPdiyJLr qwnWoKWU5oDjfpUShgX22A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVutT-0001Pw-K5; Sat, 25 Feb 2023 08:47:19 -0500 In-Reply-To: <87ttza3rwh.fsf@gmail.com> (message from Augusto Stoffel on Sat, 25 Feb 2023 12:29:02 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256720 Archived-At: > From: Augusto Stoffel > Cc: joaotavora@gmail.com, 61726@debbugs.gnu.org > Date: Sat, 25 Feb 2023 12:29:02 +0100 > > On Sat, 25 Feb 2023 at 12:57, Eli Zaretskii wrote: > > >> From: Augusto Stoffel > >> Cc: joaotavora@gmail.com, 61726@debbugs.gnu.org > >> Date: Fri, 24 Feb 2023 19:08:14 +0100 > >> > >> I also didn't attempt to make 'eglot-move-to-bytewise-column' and > >> 'eglot-bytewise-column' "correct" in the cases where 'json-serialize' > >> throws an error. I think it's clear that Eli and I have different > >> definitions "correctness" in this context, but Eli's proposal requires > >> substantial further work, including recovering from possible errors > >> raising from 'json-serialize'. > > > > No, it doesn't. All I'm asking for is to use encode-coding-string or > > encode-coding-region to measure the actual number of bytes in a UTF-8 > > sequence that corresponds to a region of text. Nothing else is > > required or requested. > > > > Can you please humor me and implement eglot-bytewise-column like that? > > I would be glad to do that, but unfortunately I'd have to ask your > advice as to how to make the corresponding adaptation of > eglot-move-to-bytewise-column. Instead of this: (defun eglot-bytewise-column () "Calculate current column using the LSP `utf-8' criterion." (- (position-bytes (point)) (position-bytes (line-beginning-position)))) use this: (defun eglot-bytewise-column () "Calculate current column using the LSP `utf-8' criterion." (length (encode-coding-region (line-beginning-position) (point) 'utf-8-unix t)))