unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: michael_heerdegen@web.de, mattiase@acm.org, 61962@debbugs.gnu.org
Subject: bug#61962: 30.0.50; New trouble with symbols with positions
Date: Tue, 07 Mar 2023 15:13:40 +0200	[thread overview]
Message-ID: <83356g7lh7.fsf@gnu.org> (raw)
In-Reply-To: <ZAcQ6UrNEPUqtwsY@ACM> (message from Alan Mackenzie on Tue, 7 Mar 2023 10:24:41 +0000)

> Date: Tue, 7 Mar 2023 10:24:41 +0000
> Cc: Mattias Engdegård <mattiase@acm.org>,
>   Eli Zaretskii <eliz@gnu.org>, 61962-done@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> I've now written safe-copy-tree, and committed it together with the fix
> in bytecomp.el to master.

Next time when you post a patch and ask for comments, please allow
some time for responses, including to those who might be in different
time zones or have less free time on their hands.  13 hours you waited
is definitely not enough.

Btw, what are these "NEW STOUGH" markers you added to bytecomp.el:

+;;;; NEW STOUGH, 2023-03-05
+                    (byte-run-strip-symbol-positions
+;;;; END OF NEW STOUGH
                    (byte-compile-sexp
                      (let ((form (read-positioning-symbols (current-buffer))))
                        (push form byte-compile-form-stack)
                        (eval-sexp-add-defvars
                         form
-                        start-read-position))))
+                        start-read-position)))
+;;;; NEW STOUGH, 2023-03-05
+                    )
+;;;; END OF NEW STOUGH
+                                              )

Also, how about adding some tests, to make sure we don't regress in
this area in the future?





  reply	other threads:[~2023-03-07 13:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 16:18 bug#61962: 30.0.50; New trouble with symbols with positions Michael Heerdegen
2023-03-04 16:34 ` Eli Zaretskii
2023-03-04 21:39   ` Mattias Engdegård
2023-03-04 21:53     ` Michael Heerdegen
2023-03-05 16:04     ` Michael Heerdegen
2023-03-05 18:39       ` Alan Mackenzie
2023-03-05 19:41         ` Michael Heerdegen
2023-03-06 13:22           ` Alan Mackenzie
2023-03-07  0:29             ` Michael Heerdegen
2023-03-07 10:24               ` Alan Mackenzie
2023-03-07 13:13                 ` Eli Zaretskii [this message]
2023-03-07 13:51                   ` Robert Pluim
2023-03-07 15:46                     ` Alan Mackenzie
2023-03-12 17:30                       ` Mattias Engdegård
2023-03-12 20:42                         ` Alan Mackenzie
2023-03-13 14:50                           ` Eli Zaretskii
2023-03-14 12:31                           ` Mattias Engdegård
2023-03-07 15:42                   ` Alan Mackenzie
2023-03-07 15:15                 ` Michael Heerdegen
2023-03-04 16:36 ` Eli Zaretskii
2023-03-04 16:47   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83356g7lh7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61962@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=mattiase@acm.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).