From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows Date: Sat, 25 Mar 2023 17:05:06 +0300 Message-ID: <83355tc4fh.fsf@gnu.org> References: <83bkkhc68v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62435@debbugs.gnu.org To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 15:06:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg4X3-00078S-Bu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 15:06:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg4Wx-0005An-QV; Sat, 25 Mar 2023 10:06:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4Ww-0005Ae-O7 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg4Ww-0005b2-Fw for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg4Ww-0007us-9h for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62435-submit@debbugs.gnu.org id=B62435.167975312630383 (code B ref 62435); Sat, 25 Mar 2023 14:06:02 +0000 Original-Received: (at 62435) by debbugs.gnu.org; 25 Mar 2023 14:05:26 +0000 Original-Received: from localhost ([127.0.0.1]:43137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4WI-0007tu-P4 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 10:05:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4WD-0007te-G9 for 62435@debbugs.gnu.org; Sat, 25 Mar 2023 10:05:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4W6-0005La-Kd; Sat, 25 Mar 2023 10:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HxhiHbsB21VV2vgTng5QhrlNrikwXaodGVzQPdJCoAM=; b=VBfEiKxsVDwS f3KSJL6gY7VKqfPkMfjCN5cmBzrXjTxHhi3Wby3wqUXC2SX4z5sIh/kn+X7AP7I9CSbDbak3rC1M9 tUNwoLf1o1L0i/fQxpZIgA9aW7a6Xn8bZNzp9vQsLY2KHiMAcFpAPUPaUoN0BAfB+vTI3exvHYXqB f7kNQ/ZDG3/1YLPYxNtMpnzle/cfy4AZVOd0Llqzl9CxNfa+3/sZYJ7PbTbWazMfEWg5WnsP2/PBe rV2ZhgJsbISLIJR84jjvG4KXlqiVIENb0+gwLA0zJE6XPZqhR4ByVCkNgNmlUVeU0eaUPmlpg32oO a8Szs53syGqLiWIHlkKicg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4W4-0000iX-IR; Sat, 25 Mar 2023 10:05:10 -0400 In-Reply-To: (message from lux on Sat, 25 Mar 2023 21:42:44 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258574 Archived-At: > From: lux > Cc: 62435@debbugs.gnu.org > Date: Sat, 25 Mar 2023 21:42:44 +0800 > > > +(defcustom eww-default-download-directory "~/Downloads/" > + "The default directory where downloaded files will be saved." > + :version "29.0" ^^^^^^ This should be "30.1". > (defun eww--download-directory () > "Return the name of the download directory. > If ~/Downloads/ exists, that will be used, and if not, the > DOWNLOAD XDG user directory will be returned. If that's > undefined, ~/Downloads/ is returned anyway." > - (or (and (file-exists-p "~/Downloads/") > - "~/Downloads/") > + (or (and (file-exists-p eww-default-download-directory) > + eww-default-download-directory) > (when-let ((dir (xdg-user-dir "DOWNLOAD"))) > (file-name-as-directory dir)) > - "~/Downloads/")) > + eww-default-download-directory)) Please update the doc string as well.