From: Eli Zaretskii <eliz@gnu.org>
To: lux <lx@shellcodes.org>
Cc: 62435@debbugs.gnu.org
Subject: bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows
Date: Sat, 25 Mar 2023 17:05:06 +0300 [thread overview]
Message-ID: <83355tc4fh.fsf@gnu.org> (raw)
In-Reply-To: <tencent_8B67466A986BCCEE96E4AFC2AF830138B109@qq.com> (message from lux on Sat, 25 Mar 2023 21:42:44 +0800)
> From: lux <lx@shellcodes.org>
> Cc: 62435@debbugs.gnu.org
> Date: Sat, 25 Mar 2023 21:42:44 +0800
>
>
> +(defcustom eww-default-download-directory "~/Downloads/"
> + "The default directory where downloaded files will be saved."
> + :version "29.0"
^^^^^^
This should be "30.1".
> (defun eww--download-directory ()
> "Return the name of the download directory.
> If ~/Downloads/ exists, that will be used, and if not, the
> DOWNLOAD XDG user directory will be returned. If that's
> undefined, ~/Downloads/ is returned anyway."
> - (or (and (file-exists-p "~/Downloads/")
> - "~/Downloads/")
> + (or (and (file-exists-p eww-default-download-directory)
> + eww-default-download-directory)
> (when-let ((dir (xdg-user-dir "DOWNLOAD")))
> (file-name-as-directory dir))
> - "~/Downloads/"))
> + eww-default-download-directory))
Please update the doc string as well.
next prev parent reply other threads:[~2023-03-25 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 11:56 bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows lux
2023-03-25 13:25 ` Eli Zaretskii
2023-03-25 13:42 ` lux
2023-03-25 14:05 ` Eli Zaretskii [this message]
2023-03-25 14:17 ` lux
2023-03-26 11:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83355tc4fh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62435@debbugs.gnu.org \
--cc=lx@shellcodes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).