From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Date: Sat, 01 Apr 2023 09:07:00 +0300 Message-ID: <83355k16gr.fsf@gnu.org> References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62578@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 01 08:07:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piUOQ-0007sy-QG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Apr 2023 08:07:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piUOI-00015g-Aa; Sat, 01 Apr 2023 02:07:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUOF-00015O-5H for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piUOE-0008R0-FO for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piUOD-0008Hs-RY for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2023 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62578 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62578-submit@debbugs.gnu.org id=B62578.168032921431841 (code B ref 62578); Sat, 01 Apr 2023 06:07:01 +0000 Original-Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 06:06:54 +0000 Original-Received: from localhost ([127.0.0.1]:35264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUO5-0008HV-Id for submit@debbugs.gnu.org; Sat, 01 Apr 2023 02:06:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUO3-0008HI-QK for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 02:06:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUNy-0008Po-CB; Sat, 01 Apr 2023 02:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aTM7ezfirHZr5MyJAR8vFXQ4n6Vl2inydP+9i2SXjds=; b=oxiY9V7+M/h6 QnNehia88MCYAMm7BsDquqvJuSu9YNzhUrBF75yfzp2+VDzIDqnOWex6FSTPszWV+6qkFiMoONd7T lmeSmPAyxkIroDmJWXFZVzce1e7dN6Blhny3CYUpJxR5h0EVukAP0We1OCcQKg1rRW9Iat+8PE2Zc yNT8ZxT7cEU3GBF73ZKoyGfBH7JAEcouYnxL6JpXz43QZC3ERoZeRBtrfOpzKhvH55DH17VleV47J F0+gZwCl5iukymg0/A6giO+Rpe3tCpUnnIucKXsgbaQNbPtjanFUzoCZ6jHNqh1iPZ8gyPV9XoU5C OZPSnBDD2axCQEZzB6vROg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUNx-0007n8-9b; Sat, 01 Apr 2023 02:06:45 -0400 In-Reply-To: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> (message from Jim Porter on Fri, 31 Mar 2023 21:41:09 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259028 Archived-At: > Date: Fri, 31 Mar 2023 21:41:09 -0700 > From: Jim Porter > > As far as I understand it, Eshell only uses synchronous processes on > MS-DOS (where 'make-process' doesn't exist). Since I don't build Emacs > for MS-DOS, and I expect not many others do either, I'm worried that > this support will regress. To avoid that, here are some regression tests. Thanks. > +(ert-deftest esh-proc-test/synchronous-proc/simple/interactive () > + "Test that synchronous processes work in an interactive shell." > + (skip-unless (executable-find "echo")) This will always skip on MS-DOS, since "echo" is not available as an external program OOTB, only if GNU Coreutils are installed. And even if Coreutils _are_ installed, a command that invokes "echo" will most probably invoke the shell builtin instead. > + (skip-unless (and (executable-find "echo") > + (executable-find "rev"))) Likewise here: "rev" is not expected to be available on MS-DOS. I think you need to rethink these tests in a way that uses different commands. My suggestion is to use the Emacs executable, since that is always available when running these tests.